Skip to:
Content

bbPress.org

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#2426 closed defect (bug) (fixed)

Cookie mix in the topic edit screen

Reported by: dontdream's profile dontdream Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.5 Priority: low
Severity: normal Version: 2.0
Component: API - Anonymous Posting Keywords: needs-patch
Cc:

Description

My friend Jane is a regular poster to my site example.com with name jane and email janeATgmail.com

Using her computer, I log in my site example.com as admin, and from the front end I edit a forum topic, e.g.

http://example.com/forums/topic/sample-topic/edit/

The topic author is John, with email johnATgmail.com - but in the Author Information box I see:

Name (required):

Johnjane

Mail (will not be published) (required):

johnATgmail.comjaneATgmail.com

Apparently, Jane's cookie is getting in the way...

WordPress 3.6 with Twenty Thirteen, bbPress 2.4 (missing in the Version dropdown)

Thank you for looking into this!

Change History (4)

#1 @johnjamesjacoby
11 years ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 2.4.1

#2 @johnjamesjacoby
11 years ago

  • Component changed from Front-end to Anonymous Posting
  • Keywords needs-patch added; needs-testing removed
  • Milestone changed from 2.4.1 to 2.5
  • Version changed from 2.3.2 to 2.0

Since this isn't a regression in 2.4, I'm punting to 2.5.

Fixing it will require new template functions for handling the output of these fields, and I'd rather not introduce new functions in a point release.

#3 @johnjamesjacoby
11 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5120:

Fix bug where nested ternary comparisons in form-anonymous.php were causing duplicated, sometimes conflicting, output.

Introduce convenience template functions for better handling and output of anonymous user form field data. Wrap complex form-anonymous.php template-part access logic in a helper function (similar to other template parts.) Deprecate ambiguous bbp_topic/reply_author() functions, in favor of author_display_name() equivalents.

Fixes #2426.

#4 @johnjamesjacoby
11 years ago

In 5121:

Improve function locations introduced in r5120. Ensures template and helper functions are in template.php. See #2426.

Note: See TracTickets for help on using tickets.