Skip to:
Content

Opened 5 years ago

Last modified 5 years ago

#2418 new defect

Error in bbp_get_user_subscribe_link function

Reported by: sgr33n Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: trunk
Component: General Keywords:
Cc:

Description

Hi,

the "before arg" doesn't really work. Infact if you declare it, then, when you will press "favorite" link, it will come back to its default value in includes/users/template.php, " | "

To try use the following code:

bbp_user_subscribe_link( array( 'before' => 'hi' ) );

then click on subscribe link, and you will see that "hi" will become the default "|".

Change History (2)

#1 @sgr33n
5 years ago

  • Version changed from 2.1 to trunk

#2 @johnjamesjacoby
5 years ago

  • Milestone changed from Awaiting Review to Future Release

This is because of BBP_Default::ajax_favorite() and BBP_Default::ajax_subscription() having hardcoded $attrs arrays.

You may want to filter bbp_after_get_user_subscribe_link_parse_args and manipulate the arguments that are passed around. That way you can be certain every call is formatted the way you want for it to be.

Agree this could be smoother, but it's pretty non-critical. Moving to Future Release.

Note: See TracTickets for help on using tickets.