Skip to:
Content

bbPress.org

Opened 8 years ago

Closed 8 years ago

#2391 closed enhancement (fixed)

Instances of HTML in translatable strings

Reported by: MZAWeb Owned by: MZAWeb
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.3.2
Component: Locale - i18n/l10n Keywords:
Cc:

Description

Attached file with a list of HTML tags in the translatable strings

Attachments (1)

html.txt (28.5 KB) - added by MZAWeb 8 years ago.

Download all attachments as: .zip

Change History (8)

@MZAWeb
8 years ago

#1 follow-up: @alex-ye
8 years ago

Something related to this, I notice that we use a lot of esc_html callbacks in the bbPress admin even with there are some HTML elements inside the strings!

Shall we open an another ticket or this the purpose for this one?!

#2 @alex-ye
8 years ago

  • Version changed from 2.1 to 2.3.2

#3 in reply to: ↑ 1 ; follow-up: @johnjamesjacoby
8 years ago

  • Milestone changed from Awaiting Review to 2.5
  • Owner set to MZAWeb

Replying to alex-ye:

Something related to this, I notice that we use a lot of esc_html callbacks in the bbPress admin even with there are some HTML elements inside the strings!

Shall we open an another ticket or this the purpose for this one?!

Any examples?

#4 in reply to: ↑ 3 @alex-ye
8 years ago

Replying to johnjamesjacoby:

Replying to alex-ye:

Something related to this, I notice that we use a lot of esc_html callbacks in the bbPress admin even with there are some HTML elements inside the strings!

Shall we open an another ticket or this the purpose for this one?!

Any examples?

I am not on my PC now... but as I remember there are some strings in the bbPress tools tabs.

#5 @netweb
8 years ago

  • Keywords needs-patch added

Based on html.txt these are the individual files, grab a file, add a patch and a comment below with the patch file name and the file it patches.

  • bbpress/includes/admin/admin.php
  • bbpress/includes/admin/settings
  • bbpress/includes/admin/metaboxes.php
  • bbpress/includes/admin/tools.php
  • bbpress/includes/admin/forums.php
  • bbpress/includes/admin/topics.php
  • bbpress/includes/admin/replies.php
  • bbpress/includes/common/functions.php
  • bbpress/includes/extend/buddypress/groups.php
  • bbpress/includes/forums/functions.php
  • bbpress/includes/topics/functions.php
  • bbpress/includes/replies/functions.php
  • bbpress/includes/users/functions.php
  • bbpress/templates/default/bbpress/form-forum.php
  • bbpress/templates/default/bbpress/form-reply.php
  • bbpress/templates/default/bbpress/form-topic.php
  • bbpress/templates/default/bbpress/form-reply-move.php
  • bbpress/templates/default/bbpress/form-topic-split.php
  • bbpress/templates/default/bbpress/form-reply-move.php
  • bbpress/templates/default/bbpress/form-topic-merge.php
  • bbpress/templates/default/bbpress/form-topic-split.php
  • bbpress/templates/default/bbpress/form-user-edit.php
  • bbpress/templates/default/bbpress/loop-single-topic.php
  • bbpress/templates/default/extras/page-forum-statistics.php
  • bbpress/templates/default/extras/page-topic-tags.php

WordPress Docs Handbook - Concatenating Strings

#6 @johnjamesjacoby
8 years ago

  • Keywords needs-patch removed
  • Milestone changed from 2.5 to 2.6

Not regressions, and we can work these over a long period, so scooting it to 2.6.

#7 @johnjamesjacoby
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Closing as fixed, as I can't find any accidentally escaped HTML. Should we find any going forward, let's reopen and patch/commit to this ticket.

Note: See TracTickets for help on using tickets.