Skip to:
Content

bbPress.org

Opened 8 years ago

Closed 7 years ago

#2381 closed defect (fixed)

The possibility of non-existant users is largely ignored.

Reported by: jondavidjohn Owned by: netweb
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.3.2
Component: API - Importers Keywords: has-patch commit
Cc:

Description

We're porting forums from an old system to a new system in which the topic and reply authors might or might not still exist.

This is causing warnings to be thrown.

This patch is just a few places we've noticed as a start to remedy this issue.

Attachments (1)

user-exists.diff (2.7 KB) - added by jondavidjohn 8 years ago.
Protect topic and reply author link calls from non-existant users

Download all attachments as: .zip

Change History (6)

@jondavidjohn
8 years ago

Protect topic and reply author link calls from non-existant users

#1 @jondavidjohn
8 years ago

I was able to mitigate this via filters for now by having bbpress treat non-existant users as anonymous. Not sure this is an optimal solution though as there might be other assumptions about Anonymous users that don't apply to non-existent ones.

#2 @netweb
8 years ago

Related: #2347

#3 @johnjamesjacoby
8 years ago

  • Component changed from Users to Importers
  • Milestone changed from Awaiting Review to 2.5

Moving to 2.5 to handle after 2.4 is released.

#4 @johnjamesjacoby
7 years ago

  • Keywords commit added; dev-feedback removed
  • Owner set to netweb

Patch looks good. There may be other places this happens, but let's deal with those as they come in.

#5 @netweb
7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 5180:

Protect topic and reply author link calls from non-existant users. Props jondavidjohn. Fixes #2381

Note: See TracTickets for help on using tickets.