Skip to:
Content

bbPress.org

Opened 12 years ago

Closed 12 years ago

#2373 closed defect (bug) (fixed)

bbp_list_forums does not fallback to title sorting

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.4 Priority: normal
Severity: normal Version: 2.2
Component: Component - Forums Keywords: has-patch
Cc:

Description

When forums do not have a menu_order set, we should try to fallback to alphabetal order where possible. In bbp_list_forums(), we only 'orderby' menu_title.

This fixes the default order for subforums to allow for alphabetal sorting by default.

Patch imminent.

Attachments (2)

sort.patch​ (496 bytes) - added by johnjamesjacoby 12 years ago.
2373.1.diff​ (564 bytes) - added by netweb 12 years ago.

Download all attachments as: .zip

Change History (5)

@johnjamesjacoby
12 years ago

#1 @johnjamesjacoby
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 5054:

Fallback to 'title' sorting in bbp_list_forums() for subforum sorting. Hat tip mordauk. Fixes #2373.

@netweb
12 years ago

#2 @netweb
12 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

The same behaviour should be seen across all locations and you drill further into the list hierarchy.
/forums

  • First Forum

-- AAA
-- BBB
-- CCC

  • Second Forum

-- DDD
-- EEE
-- FFF

Once you drill into eg. Second Forums as the 'top level' forum the list of forums are again displayed by menu_order without sorting by title (essentially displayed in the order they were created)

/forums/second-forum

  • EEE
  • FFF
  • DDD

The attached patch 2371.1.diff fixes this...

#3 @johnjamesjacoby
12 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 5058:

Fallback to title sorting in bbp_has_forums() if no menu_order is present. Props netweb. Fixes #2373.

Note: See TracTickets for help on using tickets.