Call by reference error

[mordauk]

On a fresh activation (WP multi site), I'm getting this:

Strict standards: Only variables should be passed by reference in /home/pippin/sites/trunk/wp-content/plugins/bbpress/includes/users/capabilities.php on line 163

I haven't been able to track it down yet.

[mordauk]

Call stack:

# Time Memory Function Location
1 0.0016 332096 {main}( ) ../edit.php:0
2 0.0024 391176 require_once( '/home/pippin/sites/trunk/wp-admin/admin.php' ) ../edit.php:10
3 0.0026 406512 require_once( '/home/pippin/sites/trunk/wp-load.php' ) ../admin.php:30
4 0.0029 419904 require_once( '/home/pippin/sites/trunk/wp-config.php' ) ../wp-load.php:29
5 0.0037 494696 require_once( '/home/pippin/sites/trunk/wp-settings.php' ) ../wp-config.php:103
6 0.1314 20914872 WP->init( ) ../wp-settings.php:299
7 0.1314 20914904 wp_get_current_user( ) ../class-wp.php:473
8 0.1314 20915072 get_currentuserinfo( ) ../pluggable.php:54
9 0.1328 21013416 wp_set_current_user( ) ../pluggable.php:107
10 0.1331 21043304 do_action( ) ../pluggable.php:37
11 0.1334 21049320 call_user_func_array ( ) ../plugin.php:406
12 0.1334 21049352 bbp_setup_current_user( ) ../plugin.php:406
13 0.1335 21049488 do_action( ) ../sub-actions.php:150
14 0.1335 21050912 call_user_func_array ( ) ../plugin.php:406
15 0.1335 21050944 bbp_set_current_user_default_role( ) ../plugin.php:406
16 0.1335 21051440 bbp_get_user_role( ) ../capabilities.php:248

[mordauk]

The error has gone away on it's own now, but I've tracked it down to something with bbp_add_forums_roles() or $bbp->current_user->add_role( $new_role ); in includes/users/capabilities.php

[mordauk]

Now it has come back after posting a new topic. New call stack:

# TIME MEMORY FUNCTION LOCATION
1 0.0001 236168 {main}( ) ../index.php:0
2 0.0001 239384 require( '/home/pippin/sites/trunk/wp-blog-header.php' ) ../index.php:17
3 0.1373 20907264 require_once( '/home/pippin/sites/trunk/wp-includes/template-loader.php' ) ../wp-blog-header.php:16
4 0.1564 21498240 apply_filters( ) ../template-loader.php:46
5 0.1564 21499648 call_user_func_array ( ) ../plugin.php:173
6 0.1564 21499680 bbp_template_include( ) ../plugin.php:173
7 0.1564 21499800 apply_filters( ) ../sub-actions.php:431
8 0.1576 21503232 call_user_func_array ( ) ../plugin.php:173
9 0.1576 21503264 bbp_template_include_theme_compat( ) ../plugin.php:173
10 0.1578 21505280 BBP_Shortcodes->display_topic( ) ../theme-compat.php:581
11 0.1588 21549056 bbp_get_template_part( ) ../shortcodes.php:354
12 0.1588 21549928 bbp_locate_template( ) ../template-functions.php:43
13 0.1591 21551760 load_template( ) ../template-functions.php:105
14 0.1592 21574208 require( '/home/pippin/sites/trunk/wp-content/plugins/bbpress/templates/default/bbpress/content-single-topic.php' ) ../template.php:409
15 0.1745 21625688 bbp_get_template_part( ) ../content-single-topic.php:38
16 0.1745 21626504 bbp_locate_template( ) ../template-functions.php:43
17 0.1748 21628320 load_template( ) ../template-functions.php:105
18 0.1749 21653208 require( '/home/pippin/sites/trunk/wp-content/plugins/bbpress/templates/default/bbpress/loop-replies.php' ) ../template.php:409
19 0.1760 21655056 bbp_get_template_part( ) ../loop-replies.php:50
20 0.1760 21655712 bbp_locate_template( ) ../template-functions.php:43
21 0.1763 21657536 load_template( ) ../template-functions.php:105
22 0.1764 21685456 require( '/home/pippin/sites/trunk/wp-content/plugins/bbpress/templates/default/bbpress/loop-single-reply.php' ) ../template.php:409
23 0.1883 21699456 bbp_reply_author_link( ) ../loop-single-reply.php:45
24 0.1883 21699488 bbp_get_reply_author_link( ) ../template.php:1072
25 0.1914 21705040 bbp_get_reply_author_role( ) ../template.php:1156
26 0.1915 21705976 bbp_get_user_display_role( ) ../template.php:1305
27 0.1918 21706104 bbp_get_user_role( ) ../template.php:512

[johnjamesjacoby]

Moving to 2.4. There may be a few of these, and I've fixed the one in your backtrace from bbp_get_user_role().

[mordauk]

What was it?

[johnjamesjacoby]

In 5053:

Fix PHP 5.4 by reference E_STRICT warning in bbp_get_user_role(). See #2372.

[mordauk]

Interesting. Why does array_values() cause that?

[johnjamesjacoby]

Replying to mordauk:

Interesting. Why does array_values() cause that?

Good question, and I'm not sure yet. Will need to investigate why array_values() thinks $roles is a reference in the first place.

[johnjamesjacoby]

Closing as fixed. If new PHP 5.4 errors occur, please open new tickets for them.