Skip to:
Content

bbPress.org

Opened 8 years ago

Closed 8 years ago

#2364 closed defect (fixed)

User's profile on front end deletes show admin bar preference

Reported by: imath Owned by: johnjamesjacoby
Milestone: 2.4 Priority: normal
Severity: normal Version: trunk
Component: Component - Users Keywords: commit
Cc:

Description

Hi,

version of my bbPress : 2.4-alpha-5008

If a user wants to keep the WP Admin Bar while on front, editing his profile on the front end will remove this preference. To have the WP Admin Bar back, he needs to go into his backend profile to activate the checkbox. It can be annoying to remember that if we want to keep the WP Admin Bar then, we need to edit our profile from the back end.

So i suggest 2 diffs :
option 1 : simulate a post var to preserve the preference of the user
option 2 : add some markup to the form-user-edit template.

Attachments (2)

2364-option1.diff (762 bytes) - added by imath 8 years ago.
2364-option2.diff (878 bytes) - added by imath 8 years ago.

Download all attachments as: .zip

Change History (4)

@imath
8 years ago

@imath
8 years ago

#1 @johnjamesjacoby
8 years ago

  • Keywords commit added; has-patch removed
  • Milestone changed from Awaiting Review to 2.4
  • Priority changed from low to normal
  • Severity changed from minor to normal

Option 1 makes the most sense. Option 2 would pave the way towards a new Settings page, which I'm trying to avoid for now.

#2 @johnjamesjacoby
8 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5011:

When saving a user's profile, their 'admin_bar_front' setting is accidentally wiped out by edit_user(), because the form field does not exist in bbPress's template parts.

In bbp_edit_user_handler(), check if the user has this setting; if so, add it to the $_POST superglobal to allow edit_user() to function normally.

Fixes #2364. Props imath.

Note: See TracTickets for help on using tickets.