Make Open/Close permissions consistently use 'edit_topic' instead of 'moderate'

[jondavidjohn]

This patch aims to make the Open/Close functionality consistently require 'edit_topic' capability.

There were a few places that required the 'moderate' capability, but here you only require the 'edit_topic' capability, which seems to be the most correct requirement.

​http://bbpress.trac.wordpress.org/browser/trunk/includes/topics/functions.php#L2019

[jondavidjohn]

Patch to only require 'edit_topic' for topic toggle actions.

[johnjamesjacoby]

It's possible there is a bug in this logic, since there appear to be some nested capability checks. The two checks you're pointing out here seem exclusive to moderators, since you'd likely not want a topic author to be able to close their own topic, and leave that up to conversation moderators to decide.

Leaving this open, to review these quickly in 2.4. Any other thoughts on this?

[johnjamesjacoby]

In 4985:

Remove capability pre-check from admin links functions. Remove duplicate trash-removal logic that's done inside the respective trash-link generating functions. Fixes inconsistent nested capability checks within admin link functions. See #2348.

[johnjamesjacoby]

Closing as fixed. Nested cap checks should be its own ticket.