Skip to:
Content

bbPress.org

Opened 11 years ago

Closed 11 years ago

#2345 closed defect (bug) (fixed)

Content Clear

Reported by: mordauk's profile mordauk Owned by: mordauk's profile mordauk
Milestone: 2.4 Priority: normal
Severity: minor Version: trunk
Component: Front-end Keywords: has-patch
Cc: alexvornoffice@…, pippin@…

Description

With the addition of nested replies, the clearing of the forum/topic/reply content divs has changed. This results in a minor problem with people who want to style the background of the content area. See screenshot 1.

To fix this, we just need to add a simple clearfix to the content divs. With the clearfix, we get what is shown in screenshot 2.

The blue shown in the screenshots is from my Private Replies plugin, which changes the background color of private replies to indicate that they are private.

Attachments (4)

screenshot-2.png​ (95.3 KB) - added by mordauk 11 years ago.
screenshot-1.png​ (96.6 KB) - added by mordauk 11 years ago.
content-clear.patch​ (759 bytes) - added by mordauk 11 years ago.
content-clear.2.patch​ (752 bytes) - added by mordauk 11 years ago.

Download all attachments as: .zip

Change History (14)

@mordauk
11 years ago

@mordauk
11 years ago

@mordauk
11 years ago

#1 @johnjamesjacoby
11 years ago

  • Milestone changed from 2.3.3 to 2.4

Hierarchical replies are part of 2.4.

#2 @johnjamesjacoby
11 years ago

Looks good'ish to me at a cursory glance. Thanks for the patch!

#3 @alexvorn2
11 years ago

why not to use <div style="clear: both;"></div> instead of CSS code?

Last edited 11 years ago by alexvorn2 (previous) (diff)

#4 @alexvorn2
11 years ago

  • Cc alexvornoffice@… added

#5 @mordauk
11 years ago

CSS seems cleaner to be because it doesn't require any extra markup.

#6 @alexvorn2
11 years ago

text-indent: -999px; I don't like this, so on a 4k monitor the text will show 999px to the left?

Version 0, edited 11 years ago by alexvorn2 (next)

#7 @mordauk
11 years ago

  • Cc pippin@… added

Probably better to replace it with font-size: 0.

@mordauk
11 years ago

#8 @alexvorn2
11 years ago

edited

Last edited 11 years ago by alexvorn2 (previous) (diff)

#9 @mordauk
11 years ago

Because that doesn't work for a clearfix. Here's an explanation from Chris Coyier: ​http://css-tricks.com/snippets/css/clear-fix/

#10 @johnjamesjacoby
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 5032:

Clearing CSS hack. Fixes content display issues related to hierarchical replies. Props mordauk. Fixes #2345.

Note: See TracTickets for help on using tickets.