Linking security issue/Private topics surface

[caming]

Upgraded to 2.3, and when a casual user chooses to hyperlink and opts to “Use Existing Content” and performs a search, all topic subjects posted in a Private forum (in this case, our moderator forum) are presented.

From JJJ: Sigh. No; first I’ve heard of it, and totally lame that’s happening.

[jaredatch]

I actually discovered this a month ago and posted about it in the (now removed, I beleive) Staff forums on bbPress.org. No one really read that and I just kinda forgot about it, sorry about that.

At the time I believe I was able to replicate this, so it's certainly something we want to look into and get fixed as quick as possible.

Thanks for reporting.

[johnjamesjacoby]

Fixed as part of #2337.

[johnjamesjacoby]

In 5006:

Make sure that topics and replies in private/hidden forums are excluded from the "insert links" dialogue window. Hat tip jaredatch. See #2334.