$check_ancestors Parameter Logic

[alex-ye]

Hi :), It seems that I used the "logic" word a lot in my last tickets :D

Anyway, This ticket is to enhance the functions that have the parameter $check_ancestors=true like:
bbp_is_forum_public()
bbp_is_forum_private()
bbp_is_forum_hidden()
bbp_is_forum_closed()
bbp_is_forum_open()

From my view, all the functions are different in their logical operator:

bbp_is_forum_public() and bbp_is_forum_open() : They must check all the forums in the tree to make
sure that all of them are match. which called "AND" operator.

So when you check if a forum is public, It must check all the ancestors too.

bbp_is_forum_private(),bbp_is_forum_hidden() and bbp_is_forum_closed() : They just need to check if
one forum from the tree is match, which called "OR" operator.

So, No need to check the ancestors status if the forum it self is private!

[alex-ye]

First Draft Patch

[johnjamesjacoby]

This makes sense. Moving to 2.4 to check the patch and do some testing.

[alex-ye]

Second Draft Patch

[alex-ye]

Fixing bbp_is_forum_open() function , and have some notes:

1- Why bbPress doesn't have bbp_get_opened_status_id() function?
2- If bbPress forum status is only 'Opened','Closed' why we not make this a checkbox instead of a dropdown in the admin UI?

[alex-ye]

In the third patch:

1- Remove not-needed bbp_is_forum_visibility_id and bbp_is_forum_status_id filters.
2- Make the patch index from the ROOT.
3- Remove the trailing spaces.

Give it a test and better docs :)

[johnjamesjacoby]

Good iteration here. Going to move this to 2.5 so it can get in earlier and have more time to test.

[johnjamesjacoby]

Bump to 2.6.

[netweb]

​forums-template-tags-4.patch is a refreshed patch of forums-template-tags-3.patch

[netweb]

In 2303-5.diff​, refreshed patch against /trunk (Refresh of 'forums-template-tags-4.patch​​')

[alex-ye]

Thanks @netweb :)

[johnjamesjacoby]

In 5499:

Enable forum status and visibility functions to check ancestry by extracting existing logic into new helper functions. Props alex-ye, netweb. Fixes #2303.