Skip to:
Content

bbPress.org

Opened 8 years ago

Closed 8 years ago

#2285 closed enhancement (fixed)

Enable Displayed User Fallback ID in all bbp_get_user_* Functions

Reported by: alex-ye Owned by:
Milestone: 2.3 Priority: normal
Severity: normal Version: 2.2.3
Component: Component - Users Keywords: has-patch
Cc:

Description

Enable Displayed User Fall-back ID in all bbp_get_user_* Functions

This is related to bbp_get_user_id() change in 2.3 :
http://bbpress.trac.wordpress.org/changeset/4831

All bbp_get_user_* functions should enable the $displayed_user_fallback in bbp_get_user_id() function , this was the original beehive in some way because bbp_get_user_id() was fall back to the bbp_user_id query var .

Attachments (2)

users-capabilities.patch (871 bytes) - added by alex-ye 8 years ago.
users-template-tags.patch (906 bytes) - added by alex-ye 8 years ago.

Download all attachments as: .zip

Change History (8)

#1 follow-up: @johnjamesjacoby
8 years ago

What problems does this solve?

#2 in reply to: ↑ 1 @alex-ye
8 years ago

Replying to johnjamesjacoby:

What problems does this solve?

As bbPress default templates nothing, but when you use some functions like

bbp_get_user_nicename()
bbp_get_user_blog_role()
bbp_get_user_role()

in the user profile page templates, You must pass bbp_get_displayed_user_id() to get a correct result and this is not the the beehive before changeset #4831 .

In addition , most of bbp_get_user_* functions enable the $displayed_user_fallback like :

bbp_get_user_profile_link()
bbp_get_user_profile_url()
bbp_get_user_profile_edit_link()
bbp_get_user_profile_edit_url()
bbp_get_user_display_role()
bbp_get_favorites_permalink()
bbp_get_subscriptions_permalink()
bbp_get_user_topics_created_url()
bbp_get_user_replies_created_url()

#3 follow-up: @johnjamesjacoby
8 years ago

There are some places this makes sense, and others that it doesn't. What defects exactly do your proposed patches fix (or is this an enhancement to unify the way these functions work?)

#4 in reply to: ↑ 3 @alex-ye
8 years ago

  • Type changed from defect to enhancement

Replying to johnjamesjacoby:

There are some places this makes sense, and others that it doesn't.

Can you explain to me how this not make sense ?

#5 @johnjamesjacoby
8 years ago

  • Milestone changed from Awaiting Review to 2.3

#6 @johnjamesjacoby
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4840]) Update some usages of bbp_get_user_id() to fallback to displayed user, if available. Props alex-ye. Fixes #2285.

Note: See TracTickets for help on using tickets.