Skip to:
Content

Opened 6 years ago

Closed 6 years ago

#2283 closed enhancement (fixed)

Additional CSS resets to prevent theme conflicts

Reported by: jaredatch Owned by: johnjamesjacoby
Milestone: 2.4 Priority: normal
Severity: normal Version:
Component: Appearance - Theme Compatibility Keywords: has-patch needs-testing
Cc: nashwan.doaqan@…

Description

We need to add some additional resets to a few elements of the forum elements to help with theme compatibility.

Specifically the list items within #bbpress. We need to make sure and there is no background images and set a default padding.

Attaching a screenshot of a site that forum user has that is broken due to their theme's CSS conflicting with bbPress.

Attachments (5)

broken-theme-css.png (20.9 KB) - added by jaredatch 6 years ago.
bppress-top-forum-search.png (20.2 KB) - added by jaredatch 6 years ago.
bbpress-search-results-h3.png (37.5 KB) - added by jaredatch 6 years ago.
bbpress-search-page-search.png (13.7 KB) - added by jaredatch 6 years ago.
2283.diff (1.1 KB) - added by jaredatch 6 years ago.

Download all attachments as: .zip

Change History (9)

#1 @alex-ye
6 years ago

  • Cc nashwan.doaqan@… added

#2 @jaredatch
6 years ago

Uploaded screenshots of a few more CSS tweak/resets I think we can include to better our theme compatibility.

Two are dealing with the new search input. We can provide some basic CSS on those so they are tamed.

Secondly is in the search results, .bbp-reply-header uses an h3 which most themes are going to style wildly different. Especially since this is an h3 within the primary content area. They way it looks on bbPress.org looks good, so maybe we can just set similar styling.

@jaredatch
6 years ago

#3 @jaredatch
6 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

Patch tames/resets

  • bbPress list items. Specifically to make sure there is no background image or padding.
  • bbPress search form display. Also hides the .hidden label similar to on bbPress.org
  • h3 used in forum, topic, reply titles. Set base size, reset background, border, padding, and text transform.

Tested against TwentyTen/Eleven/Twelve, Genesis 1.8.2, and a few custom client themes.

The search form input sizing (namely the height) is still an issue sometimes, but I figure we probably want to avoid hard coding any dimensions.

#4 @johnjamesjacoby
6 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5007:

Additional CSS resets to improve theme compatibility for search and list items. Props jaredatch. Fixes #2283.

Note: See TracTickets for help on using tickets.