Skip to:

Opened 11 years ago

Closed 10 years ago

#2270 closed defect (bug) (fixed)

Remove or hide the forum dropdown from the reply edit screen

Reported by: mzaweb's profile MZAWeb Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.1
Component: General - Administration Keywords: needs-refresh early
Cc: wordpress@…, pippin@…


It's confusing, and modifying that value breaks the reply.

Two options come to mind:

1) Hide it and have a way to make it visible for troubleshooting
2) Remove it and add a tool in Tools that traverses all Topics and fixes the Forum->Topic->Reply relationship.

Attachments (2)

Screen Shot 2013-03-20 at 4.59.08 PM.png (23.1 KB) - added by MZAWeb 11 years ago.
2270.patch (2.7 KB) - added by MZAWeb 11 years ago.

Download all attachments as: .zip

Change History (16)

11 years ago

#1 @MZAWeb
11 years ago

  • Cc wordpress@… added
  • Keywords has-patch added; dev-feedback removed

2270.patch hides the dropdown, and introduces the bbp_show_forum_dropdown_on_replies filter to enable it.

#2 @MZAWeb
11 years ago

I didn't realize point 2 is already in core. bbp_admin_repair_forum_meta() does that.

So I think that's all.

#3 @MZAWeb
11 years ago

  • Milestone changed from Future Release to 2.4

#4 @mordauk
11 years ago

  • Cc pippin@… added

I noticed this the other day. Should the forum be automatically selected based on the reply ID entered?

#5 @alex-ye
11 years ago

Instead of removing it, Why not only print the forum title with a link to edit screen, I think it's good to know the reply forum easily :)

#6 @johnjamesjacoby
11 years ago

  • Milestone changed from 2.4 to 2.5

Torn about this. I want Key Masters to be able to edit all of the meta data, but also don't want to allow them to mismatch it.

Moving to 2.5.

#7 @johnjamesjacoby
11 years ago

  • Milestone changed from 2.5 to 2.6

Trivial, so moving to 2.6.

#8 @netweb
11 years ago

Related: #2463

I'm against this in it's current iteration, primarily if a new user to bbPress has just imported forums from another platform and the import didn't go so well (sadly, still does happen) they can have 'Orphaned' forums, topics and replies with bbp_get_orphan_status_id.

I don't think they should have to search to find a filter to turn this on to correct a mismatched forum id.

#9 @johnjamesjacoby
11 years ago

  • Milestone 2.6 deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Thanks for the insight netweb. I'm in agreement with you on the why's. I wonder if we can introduce a smarter UI for this, or maybe a tool to fix the orphaned or misaligned replies?

Closing this as worksforme, and let's rethink this UI in a future release.

#10 @johnjamesjacoby
11 years ago

We could also only show the UI when we see that the forum is misaligned, and suggest an update?

#11 @johnjamesjacoby
11 years ago

  • Keywords needs-refresh early added; has-patch removed
  • Milestone set to 2.6
  • Resolution worksforme deleted
  • Status changed from closed to reopened

Let's do that. Let's hide the UI unless we see a mismatch, and only show the forum ID if a mismatch is visible.

Going to reopen and assign to myself, to do in conjunction with #2463.

#12 @johnjamesjacoby
11 years ago

  • Owner set to johnjamesjacoby
  • Status changed from reopened to new

#13 @netweb
11 years ago

Updated the 'Topic Attributes' and 'Reply Attributes' screenshots in #2463

Basically separating what is 'core' meta from what is not 'core' meta for topics and replies.

#14 @johnjamesjacoby
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 5510:

Only allow direct modification of reply forum meta when there is a mismatch with the topic forum.

This prevents moderators and keymasters from creating mismatches and leaves the tool available only for repairs (usually after a migration from a different platform.) Fixes #2270.

Note: See TracTickets for help on using tickets.