Skip to:
Content

bbPress.org

Opened 13 years ago

Closed 13 years ago

#2231 closed defect (bug) (fixed)

is_super_admin() usage too strict in many cases

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.3 Priority: normal
Severity: normal Version: 2.1
Component: Component - Users Keywords:
Cc:

Description

There are a few places in bbPress where is_super_admin() checks were previously used in place of checking for Key Master status. Now that dynamic roles and caps are solid, we can reliably check for the 'keep_gate' capability.

I propose we introduce a bbp_is_user_keymaster() function, similar to is_super_admin(), to assist with this, and use it everywhere is_super_admin() is used that isn't specific to granting or revoking super admin access via the profile page.

Attachments (1)

2231.patch (18.7 KB) - added by johnjamesjacoby 13 years ago.

Download all attachments as: .zip

Change History (2)

#1 @johnjamesjacoby
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4783]) Replace is_super_admin() usages with bbp_is_user_keymaster() where appropriate. Fixes #2231.

Note: See TracTickets for help on using tickets.