Skip to:

Opened 11 years ago

Closed 11 years ago

#2227 closed defect (bug) (fixed)

BuddyPress 1.7-beta - Group Forums - Sticky trouble

Reported by: imath's profile imath Owned by:
Milestone: 2.3 Priority: normal
Severity: normal Version: trunk
Component: Extend - BuddyPress Keywords: has-patch



Versions used :

1) Super Sticky in Group Forums :
let's say i have 2 topics (topic A and topic B). As a group admin or the superadmin, i choose to "stick to front" topic B. Then back in forum archive i want to read topic A, the url takes the slug of topic A but the content is not topic A, it's the one of topic B (the "sticked to front" one).

Now if i add a topic C and choose 'Super Sticky' in the topic type selectbox, once posted i'm redirected to an url containing the slug of topic C but the content is the one of topic B (the previous "sticked to front" topic).

Back in the forum archive of the group, i have 2 topics Sticked to front (topic B and C) :

  • If i click on the topic B link, the slug is the one of topic B but the content is the one of topic C
  • If i click on the topic C link, the slug is the one of topic C but the content is the one of topic B.
  • If i click on the topic A link, the slug is the one of topic A but the content is the one of topic C (the latest "sticked to front" topic)

So unless i edit topic B and topic C to be unsticked, topic A will never be readable again :(

2) Sticky in Group Forums :
When creating a new topic, in the topic type select box i have 3 choices : Normal, Sticky, Super Sticky.

Let's say i choose Sticky and post my topic. Then i edit the topic, the option of the selectbox is not on Sticky but on Normal. I don't know if it's the right behavior, but if nothing happens when selecting Sticky, maybe the option shouldn't show ?

Attachments (1)

2227.diff (3.2 KB) - added by imath 11 years ago.

Download all attachments as: .zip

Change History (5)

#1 @imath
11 years ago

  • Keywords has-patch added

I needed to make it work so i made this patch. I'm sorry if i did things wrong. But it's working for me. Sharing it here.. in case it can help you find the best way...
What the patch does :

  • make sure the _bbp_forum_id is set once the topic is inserted else, the sticky is not applyed when creating a first topic
  • avoids super sticky to be added to the list of topics when in group forums (else, the topic of one group when stick to front can be in another group...)

#2 @imath
11 years ago

As discussed on IRC, i split this ticket in 2 to only keep here the BuddyPress 1.7 Group Forums sticky trouble.

For the issue about the fact sticky types are not saved when first creating a topic, i've just added this ticket #2230

11 years ago

#3 @johnjamesjacoby
11 years ago

  • Milestone changed from Awaiting Review to 2.3

#4 @johnjamesjacoby
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4809]) Hide super sticky related output from group forums. Props imath. Fixes #2227.

Note: See TracTickets for help on using tickets.