Redirect to the home page after logout from a private forum/topic/reply

[alex-ye]

Hi bbPress Lovers , When the user logout from a private forum/topic/reply the WordPress redirect the page to 404 error page .

I think we should redirect it to the home page since the private forum/topic/reply are only shown for users .

I prepare some codes about that , but I am not sure that this is a thing should be in the core !

[johnjamesjacoby]

This needs to happen in a few places; basically, the redirects need to be a bit smarter. Too late for 2.3, so moving to 2.4.

[alex-ye]

First Draft Patch

[johnjamesjacoby]

No time. Moving to 2.5.

[MZAWeb]

Also the code now is doing:

// Rejig the $redirect_to
if ( !isset( $_SERVER['REDIRECT_URL'] ) || ( $redirect_to !== home_url( $_SERVER['REDIRECT_URL'] ) ) ) {
	$redirect_to = isset( $_SERVER['HTTP_REFERER'] ) ? $_SERVER['HTTP_REFERER'] : '';
}

$redirect_to = ( is_ssl() ? 'https://' : 'http://' ) . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI'];

That if doesn't make any sense, as the last line is overwriting $redirect_to.

[alex-ye]

Replying to MZAWeb:

That if doesn't make any sense, as the last line is overwriting $redirect_to.

hhhh, I don't know what I was thinking about :D
I will update the patch soon..

[alex-ye]

Thanks MZAWeb :)

[mordauk]

Is there a function in bbPress for can_view( $post_id )? If so, that would make this dramatically simpler.

[mordauk]

Ah, here we go. How about just using bbp_user_can_view_forum()?

[alex-ye]

Sorry, but bbp_user_can_view_forum() doesn't work! for this reasons:

1- A BUG: if you see the function source code the check bbp_is_user_keymaster() doesn't use the $user_id variable.

I will open a another ticket about this now.

2- We need to check if the visitor can read the forum, so will need to pass the user_id => 0 and this will not work! because bbp_is_user_keymaster() will fallback to the current user ID :(

So..

I think we should introduce some functions if we want a really clean solution, maybe something like bbp_user_can_view_topic() and bbp_user_can_view_reply() and we should add a fourth argument in bbp_user_can_view_forum() let's called it guest=>(bool)

What's your thoughts?!

[alex-ye]

0.2

[johnjamesjacoby]

Patch looks okay at a cursory glance. Let's move this to 2.6 early, and get it in to test right away.

[johnjamesjacoby]

Bump to 2.7.

[johnjamesjacoby]

Bumping all 2.7 to 2.8 milestone.

[johnjamesjacoby]

Working on a different approach for 2.7 now.

[johnjamesjacoby]

In 6863:

Login: Updates to bbp_logout_url():

• Removes Apache-only REDIRECT_URL usage
• Defaults to the Referer (for smart redirects)
• Adds a filter to the redirect_to string
• Validates the redirect_to after being filtered
• Falls back to bbp_get_root_url() if invalid
• Ensures that custom $redirect_to values are preserved

Fixes #2188.