Skip to:
Content

bbPress.org

Opened 9 years ago

Closed 8 years ago

#2187 closed enhancement (fixed)

Close a topic from the back-end interface

Reported by: alex-ye Owned by:
Milestone: 2.4 Priority: normal
Severity: normal Version: 2.2.3
Component: General - Administration Keywords: has-patch
Cc: nashwan.doaqan@…, wordpress@…, jared@…, alexvornoffice@…, pippin@…, jkudish

Description

Hi , Allow the user to close/open a topic from the back-end interface , I think we should add a custom bbPress discussion meta-box in the admin UI .

Attachments (2)

2187.diff (3.8 KB) - added by jkudish 8 years ago.
2187.2.diff (3.5 KB) - added by jkudish 8 years ago.

Download all attachments as: .zip

Change History (22)

#1 @alex-ye
9 years ago

  • Cc nashwan.doaqan@… added

#2 @alex-ye
9 years ago

  • Type changed from defect to enhancement

#3 @johnjamesjacoby
9 years ago

  • Keywords 2nd-opinion removed
  • Milestone changed from Awaiting Review to 2.4

#4 follow-up: @MZAWeb
9 years ago

  • Cc wordpress@… added

I don't quite get this one. You CAN close a topic from the admin, with the close action link http://screenshots.mzaweb.com/kyAC

#5 in reply to: ↑ 4 @alex-ye
9 years ago

Replying to MZAWeb:

I don't quite get this one. You CAN close a topic from the admin, with the close action link http://screenshots.mzaweb.com/kyAC

I know , but I am asking to add the ability in the edit topic screen .

#6 @jaredatch
9 years ago

  • Cc jared@… added

#7 @alexvorn2
9 years ago

  • Cc alexvornoffice@… added

#8 @johnjamesjacoby
9 years ago

  • Milestone changed from 2.4 to 2.5

No time. Moving to 2.5.

#9 @mordauk
8 years ago

  • Cc pippin@… added

I'd be happy to work on this.

@jkudish
8 years ago

#10 @jkudish
8 years ago

  • Cc jkudish added
  • Keywords has-patch added; needs-patch removed

I've made a patch that adds a dropdown to be able to change the status in the admin: https://dl.dropboxusercontent.com/s/iqk6xxvpz4gkqz7/2013-07-28%20at%201.31%20PM%202x.png

#11 @alex-ye
8 years ago

I think it's better to add "Discussion" meta-box, It will be helpful because we plan to allow the plngbacks/trackbacks in the topics and it will be easy for the plugins to add more options in this context.

In addition adding a dropdown with "Status" label make the user confuse with the "Status" option in the WordPress "Publish" meta-box.

#12 @jkudish
8 years ago

We really don't need to add another metabox to an already crowded interface. The status makes sense with the topic attributes.

After chatting with JJJ in person at the WCSF contributor day, I'm attaching a revised approach that uses jQuery to remove the default status field and replaces it with the custom one. The overall approach is cleaner to before both from a code and UX point of view. Best of all, it remains backward compatible for users without JS.

@jkudish
8 years ago

#13 @alex-ye
8 years ago

I didn't get your point about "crowded interface", the edit-topic screen only have 5 meta-boxes by default and WordPress edit-post have 9 ! In also the "Status" option in the "Publish" meta-box still in use.. and I use it personally for drafts.

if you really want to make this a dropdown in the "Topic Attributes" meta-box, Why not we add the custom-topic-status and replace "Open" status by "Publish" ?!

In another topic:

I am really confuse with bbp_is_topic_closed() function, because the Closed Topic in bbPress is a post with a 'closed' status, so some functions like bbp_is_topic_published() always return false! this not make sense to me. When we register some custom-topic-status it will be hard to give the user the ability to use the custom-status and 'closed' at the same time!

because of that I suggest to re-work the Topic Open/Close logic before adding some elements to the UI.

Last edited 8 years ago by alex-ye (previous) (diff)

#14 @johnjamesjacoby
8 years ago

In 5060:

Normalize forum, topic, and reply dropdown form fields and associated functions. Includes several new functions with _get_ equivalents to replace incorrectly named _select() functions.

First pass at adding custom topic status handling. Props jkudish. See #2187.

Also replaces $wpdb->update() calls with wp_update_post() in associated functions. Fixes #2351.

#15 follow-up: @mordauk
8 years ago

Is there a reason you changed orderby back to just menu_order in trunk/includes/forums/template.php?

#16 @alex-ye
8 years ago

John, is there a chance to solve this bug
https://bbpress.trac.wordpress.org/ticket/2233

Adding the topic status dropdown will make the users notice about it,
even if it's a WordPress bug, Can we make a hack until WordPress 3.7 ?!

#17 @MZAWeb
8 years ago

bbp_get_topic_statuses is awesome! it was a pain to add custom statii before.

#18 in reply to: ↑ 15 @johnjamesjacoby
8 years ago

Replying to mordauk:

Is there a reason you changed orderby back to just menu_order in trunk/includes/forums/template.php?

Accident. Will revert that bit.

#19 @johnjamesjacoby
8 years ago

  • Milestone changed from 2.5 to 2.4

#20 @johnjamesjacoby
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Just audited the 'orderby' arguments, and this appears to have been fixed in r5063.

Note: See TracTickets for help on using tickets.