Skip to:
Content

bbPress.org

Opened 13 years ago

Closed 13 years ago

#2149 closed defect (bug) (fixed)

Topic & Reply Filter Priorities

Reported by: netweb's profile netweb Owned by:
Milestone: 2.3 Priority: normal
Severity: normal Version: 2.2
Component: API - Actions/Filters Keywords:
Cc: alexvornoffice@…

Description

Originally seen in this post on bbpress.org

Topic or Reply URL's wrapped in single-quote or double-quote presume the end quote is part of the URL.

Steps to reproduce:

1) Write a topic or reply:

The websites 'http://wordpress.org' and "http://bbpress.org" are awesome

2) Output (html source):

<p>The websites ‘<a href="http://wordpress.org&amp;#8217" rel="nofollow">http://wordpress.org&amp;#8217</a>; and “<a href="http://bbpress.org&amp;#8221" rel="nofollow">http://bbpress.org&amp;#8221</a>; are awesome</p>

(front end)

The websites ‘http://wordpress.org&#8217; and “http://bbpress.org&#8221; are awesome

BuddyPress #2443 Make sure that make_clickable is run before wptexturize

WordPress #17097 make_clickable() regex should exclude close-quotation marks after URLs

http://bbpress.trac.wordpress.org/browser/trunk/includes/core/filters.php#L122

I tried all 6 possible permutations for the priorities of wptexturize, convert_chars and make_clickable without successful patch, I'm done ;)

Change History (4)

#1 @alexvorn2
13 years ago

  • Cc alexvornoffice@… added

#2 @johnjamesjacoby
13 years ago

  • Milestone changed from Awaiting Review to 2.3

#3 @jmdodd
13 years ago

WordPress behavior in posts and comments: neither URL is linked.

WordPress runs wp_texturize and convert_chars at 10, make_clickable at 9.

#4 @johnjamesjacoby
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4714]) Improve usage of make_clickable filter on topic and reply content. Fixes #2149.

Note: See TracTickets for help on using tickets.