Usernames and user-IDs mix if username is numeric.

[steilenhang]

I have users at my site with numbers as usernames. When you click one of them in the forum to see his profile, the url might look like this: example.com/forums/users/8048 with 8048 beeing his username. But the profile that shows up does not belong to username 8048, it belongs to userID 8048 which is someone else. You never get to the right profile.

The story continiues with the links on the profile. It keeps mixing usernames and user-IDs.

Example:

User One: ID 1, username 8

User Two: ID 8, username 15

User Three: ID 15, username 1

Lets say you want to view the profile of user One. You will be shown the profile of user Two. If you then click on one of the links on the profile (favorites etc.), you will be sendt to user Three to view his favorites whatever you clicked..

A little hard to explain, but I think you get the idea. Hopefully someone understands what happens here.

[johnjamesjacoby]

Huh. That's definitely a bug. I'll check it out for 2.3.

[johnjamesjacoby]

Quick note on this: users in a multisite installation have to have a letter in their username.

[johnjamesjacoby]

(In [4670]) Users on single-site installations can have all-numeric usernames, causing profile URLs like '/forums/users/55555/' to be parsed incorrectly.

In bbp_parse_query(), check the 'permalink_structure' option before checking if the 'bbp_user' WP query variable is not numeric.

This has the potentially negative side-effect of not being able to use the query-var with a numeric user ID when using pretty permalinks, but that was never intended behavior anyways.

Fixes #2136.

[steilenhang]

Wow John, that was quick!