Skip to:
Content

bbPress.org

Opened 13 years ago

Closed 11 years ago

#2125 closed defect (bug) (fixed)

bbPress 1.x / BuddyPress import doesn't include topic open/closed status

Reported by: netweb's profile netweb Owned by: netweb's profile netweb
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.2
Component: API - Importers Keywords: needs-patch
Cc: info@…

Description

The bbPress1.php importer doesn't check to see if a topic/thread is 'open' or 'closed' to new replies.

After importing, if you navigate to what was a closed topic in bbPress 1.x or BuddyPress Group Forum users can now add replies to the imported bbPress/BuddyPress topic.

Attachments (1)

2125.diff​ (1.7 KB) - added by netweb 13 years ago.

Download all attachments as: .zip

Change History (14)

@netweb
13 years ago

#1 @johnjamesjacoby
13 years ago

  • Milestone changed from Awaiting Review to 2.3

Patch is no good if it's against files that aren't part of bbPress. :)

#2 @johnjamesjacoby
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4625]) In bbPress 1.x converter, use topic_open to make sure topics stay closed after conversion. Props netweb. Fixed #2125.

#3 @johnjamesjacoby
13 years ago

Can you confirm that trashed and spam topic status is still retained?

#4 @johnjamesjacoby
13 years ago

  • Milestone changed from 2.3 to 2.4
  • Resolution fixed deleted
  • Status changed from closed to reopened

#5 @johnjamesjacoby
13 years ago

(In [4637]) Revert r4625, as it could cause spam topics to become published. Will need to rethink/revisit this in 2.4. See #2125.

#6 @netweb
13 years ago

  • Keywords has-patch removed

#7 @wdfee
13 years ago

  • Cc info@… added

#8 @johnjamesjacoby
13 years ago

  • Milestone changed from 2.4 to 2.5

No time. Moving to 2.5.

#9 @netweb
13 years ago

Related: #2130
(Some useful reference info in that ticket of table/field names related to this issue)

#10 @johnjamesjacoby
12 years ago

  • Milestone changed from 2.5 to 2.6

Consolidating status and visibility down into 1 field is coming back to haunt us.

Let's move this to 2.6, since we're still not confident how best to approach this in an efficient way.

#11 @johnjamesjacoby
12 years ago

  • Owner set to netweb
  • Status changed from reopened to new

#12 @netweb
12 years ago

  • Keywords needs-patch added

With the updated closed topic importer method introduced in r5425 this should now be doable.

#13 @netweb
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 5517:

In bbPress 1.x converter add support for closed topics via improved method in r5425.
Props netweb. Fixes #2125.

Note: See TracTickets for help on using tickets.