WP_Role contains role name, instead of role slug

[scribu]

I recently ran into some capability issues after updating bbPress to 2.2.3 (and WordPress to 3.5).

Compared with native WP roles, the bbPress role objects don't seem to have the correct value for the 'name' property.

Steps to reproduce:

var_dump( $GLOBALS['wp_roles']->get_role( 'bbp_moderator' )->name );

Expected result:

'bbp_moderator'

Actual result:

'Moderator'

Not sure if this is a bug in WP's tangled role API or if bbPress is _doing_it_wrong().

[johnjamesjacoby]

Likely bbPress is doing it wrong, and I'm translating the role somewhere.

[johnjamesjacoby]

(In [4601]) In bbp_add_forums_roles(), use $role_id instead of literal translated role name. Fixes #2105.