Skip to:
Content

bbPress.org

Opened 12 years ago

Closed 12 years ago

#2093 closed defect (bug) (fixed)

Notify of Follow Up Replies Gets Unchecked on Front End Edit

Reported by: mordauk's profile mordauk Owned by:
Milestone: 2.3 Priority: high
Severity: normal Version: 2.2.2
Component: Component - Replies Keywords: has-patch
Cc: ethitter

Description

When editing a reply from the front end (both your own and replies from other users), the "Notify me of followup replies" checkbox gets unchecked, even if it was previously checked.

I'm not sure if it happens every time but I've seen it happen enough to know it's definitely a bug.

I'll try and make a patch shortly.

Attachments (1)

2093.patch​ (477 bytes) - added by ethitter 12 years ago.

Download all attachments as: .zip

Change History (4)

#1 @johnjamesjacoby
12 years ago

  • Milestone changed from Awaiting Review to 2.3

Should be easy to look into for 2.3.

@ethitter
12 years ago

#2 @ethitter
12 years ago

  • Cc ethitter added
  • Keywords has-patch added; needs-patch removed

In bbp_get_topic_id(), the two checks for bbp_is_single_topic() also check bbp_is_topic_edit().

The bbp_is_single_reply() case didn't get the same treatment, causing bbp_get_topic_id() to return an incorrect value (0) when editing a reply. ​2093.patch addresses this problem.

See ​includes/topics/template-tags.php#L380.

#3 @johnjamesjacoby
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4574]) Add bbp_is_reply_edit() check to bbp_get_topic_id().

  • Addresses bug where topic subscription status would show incorrect value.
  • Props ethitter.
  • Fixes #2093.
Note: See TracTickets for help on using tickets.