Skip to:
Content

bbPress.org

Changes between Version 1 and Version 2 of Ticket #2090, comment 4


Ignore:
Timestamp:
08/13/2013 02:46:08 AM (12 years ago)
Author:
aaclayton
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2090, comment 4

    v1 v2  
    77Unfortunately, bbp_get_topic_trash_link() runs esc_html() on this argument which escapes my icon. I suggest that esc_html() be removed from the trash link function as a developer supplied argument should hardly be treated as "untrusted" by its own theme.
    88
    9 The same problem affects bbp_get_reply_trash_link() and bbp_get_topic_split_link(). Considering it would be a super quick fix, I hope this could maybe be squeezed in for 2.4.
     9The same problem affects a few other admin links as well: bbp_get_reply_trash_link(), bbp_get_topic_split_link(), and bbp_get_reply_move_link(). It would really be great to get these escapes removed. Considering it would be a super quick fix, I hope this could maybe be squeezed in for 2.4.