Skip to:
Content

bbPress.org

Opened 13 years ago

Closed 13 years ago

#2056 closed defect (bug) (fixed)

Remove all uses of extract() within bbPress

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.3 Priority: normal
Severity: normal Version: 2.1
Component: Tools - Code Improvements Keywords: needs-patch
Cc:

Description

See ​http://core.trac.wordpress.org/ticket/22400 for WordPress core equivalent.

extract() is error prone and ugly, so lets get rid of it in 2.3.

Change History (21)

#1 @johnjamesjacoby
13 years ago

(In [4480]) Extract:

  • Remove extract() calls from some statistics functions.
  • See #2056.

#2 @johnjamesjacoby
13 years ago

(In [4481]) Extract:

  • Remove extract() from bbp_filter_anonymous_post_data().
  • See #2056.

#3 @johnjamesjacoby
13 years ago

(In [4482]) Extract:

  • Remove extract() from bbp_wp_login_action().
  • See #2056.

#4 @johnjamesjacoby
13 years ago

(In [4483]) Extract:

  • Remove extract() from bbp_get_breadcrumb().
  • Other general code cleanup.
  • See #2056.

#5 @johnjamesjacoby
13 years ago

(In [4484]) Extract:

  • Remove extract() from bbp_get_the_content().
  • Other general code cleanup.
  • See #2056.

#6 @johnjamesjacoby
13 years ago

(In [4485]) Extract:

  • Remove extract() from bbp_get_dropdown().
  • Other general code cleanup.
  • See #2056.

#7 @johnjamesjacoby
13 years ago

(In [4486]) Extract:

  • Remove extract() from bbp_update_reply_revision_log().
  • Other general code cleanup.
  • See #2056.

#8 @johnjamesjacoby
13 years ago

(In [4487]) Extract:

  • Remove extract() from bbp_create_initial_content().
  • See #2056.

#9 @johnjamesjacoby
13 years ago

(In [4488]) Extract:

  • Remove extract() from bbp_update_forum().
  • See #2056.

#10 @johnjamesjacoby
13 years ago

(In [4490]) Extract:

  • Remove extract() from bbp_update_topic_revision_log().
  • See #2056.

#11 @alexvorn2
13 years ago

what about widgets.php?

#12 @johnjamesjacoby
13 years ago

(In [4493]) Extract:

  • Remove extract() from widgets.
  • See #2056.

#13 @johnjamesjacoby
13 years ago

(In [4497]) Extract:

  • Remove extract() from extra statistics page template.
  • See #2056.

#14 @johnjamesjacoby
13 years ago

(In [4498]) Extract:

  • Remove extract() usages from /users/template-tag.php.
  • See #2056.

#15 @johnjamesjacoby
13 years ago

(In [4499]) Extract:

  • Remove extract() from bbp_check_for_duplicate().
  • Improve code in bbp_check_for_duplicate() to support this.
  • See #2056.

#16 @johnjamesjacoby
13 years ago

(In [4501]) Extract:

  • Remove unused BBP_Forum_Walker class, and bbp_walk_forum function, that use extract().
  • See #2056.

#17 @johnjamesjacoby
13 years ago

(In [4502]) Extract:

  • Remove extract() from bbp_get_single_forum_description().
  • See #2056.

#18 @johnjamesjacoby
13 years ago

(In [4503]) Extract:

  • Remove extract() from bbp_list_forums().
  • See #2056.

#19 @johnjamesjacoby
13 years ago

(In [4506]) Extract:

  • Remove extract() usages from /topics/template-tags.php.
  • See #2056.

#20 @johnjamesjacoby
13 years ago

(In [4507]) Extract:

  • Remove extract() usages from /replies/template-tags.php.
  • See #2056.

#21 @johnjamesjacoby
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4508]) Extract:

  • Clean up bbp_parse_args() usages and inline documents.
  • Fixes #2056.
Note: See TracTickets for help on using tickets.