Skip to:
Content

bbPress.org

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#2015 closed defect (bug) (fixed)

Split and merge of replies breaks topic/reply order when replies precede topic

Reported by: jmdodd's profile jmdodd Owned by:
Milestone: 2.2 Priority: normal
Severity: normal Version: 2.1
Component: Component - Topics Keywords: has-patch
Cc:

Description

When an older topic is merged into a newer topic, the newer topic is backdated to 1 second before the post date of the older topic.

However, this backdating does not occur in the destination topic when a string of older replies is split and merged into a newer topic. This results in an unordered display case where the older replies, then the topic, and then the newer replies are displayed in the topic thread.

Suggested fix: backdate the destination topic for the split and merge case if necessary (see bbp_merge_topic_handler(): Date Check).

Attachments (1)

2015.diff (1.1 KB) - added by jmdodd 13 years ago.

Download all attachments as: .zip

Change History (5)

@jmdodd
13 years ago

#1 @jmdodd
13 years ago

  • Keywords has-patch added

#2 @johnjamesjacoby
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4362]) Topic Split:

  • When splitting a topic off into an existing topic, use the same kludge from topic-merge, and rejig the post_date by 1 second.
  • This keeps topics and replies in the correct order after splitting part of a topic, into another topic.
  • Props jmdodd.
  • Fixes #2015.

#3 @johnjamesjacoby
13 years ago

  • Milestone changed from 2.3 to 2.2

Fixed for 2.2.

#4 @johnjamesjacoby
13 years ago

  • Component changed from General to Topics
Note: See TracTickets for help on using tickets.