Skip to:
Content

bbPress.org

Opened 9 years ago

Closed 9 years ago

#1975 closed defect (bug) (fixed)

bbp-includes is becoming difficult to navigate

Reported by: johnjamesjacoby Owned by: johnjamesjacoby
Milestone: 2.2 Priority: high
Severity: normal Version: 2.1
Component: Tools - Code Improvements Keywords:
Cc:

Description

Problem: /bbp-includes/ is becoming a mess:

  • Difficult to navigate through files and code.
  • Becoming hard to decide where code should live.
  • File prefixes and suffixes are becoming increasingly redundant.

Solution: Create sub folders in /bbp-includes/ for:

  • admin
  • core
  • common
  • extend
  • forums
  • topics
  • replies
  • users

In addition, bbpress()->includes_dir and bbpress()->includes_url could be introduced to make including and enqueueing files easier. Some other enhancements are:

  • Splitting the BuddyPress file up into smaller parts, for activity/group/profile.
  • Removing superfluous bbp- file prefix.
  • Lengthening abbreviated file suffixes -caps/-capabilities, -template/-template-tags.

Everything should obviously be moved to retain file version history.

Attachments (1)

1975.diff (6.5 KB) - added by jaredatch 9 years ago.

Download all attachments as: .zip

Change History (5)

@jaredatch
9 years ago

#1 @jaredatch
9 years ago

bah ignore that patch :\

#2 @johnjamesjacoby
9 years ago

See: r4248, r4249. I goofed the commit messages for them both.

#3 @johnjamesjacoby
9 years ago

(In [4250]) Code Improvement:

  • Remove bbp- prefixes from admin files.
  • Adjust include paths.
  • See #1975.

#4 @johnjamesjacoby
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4252]) Add index.php warning files in new bbp-includes folders. Fixes #1975.

Note: See TracTickets for help on using tickets.