Skip to:
Content

bbPress.org

Opened 8 years ago

Closed 8 years ago

#1959 closed defect (fixed)

Element script must not have attribute charset unless attribute src is also specified.

Reported by: plescheff Owned by:
Milestone: 2.2 Priority: normal
Severity: normal Version: 2.1.2
Component: General Keywords:
Cc:

Description

Using bbPress 2.1.2, WordPress 3.4.2.

HTML Tidy (HTML5 mode) is reporting that "Element script must not have attribute charset unless attribute src is also specified."

bbPress adds the script on every page, so validation fails.

File: wp-content\plugins\bbpress\bbp-theme-compat\bbpress-functions.php

Patch (line 196):

-               <script type="text/javascript" charset="utf-8">
+               <script type="text/javascript">

Change History (4)

#1 @alexvorn2
8 years ago

  • Resolution set to invalid
  • Status changed from new to closed

#2 @johnjamesjacoby
8 years ago

  • Milestone changed from Awaiting Review to 2.2
  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Type changed from enhancement to defect

This is valid. Reopening.

#4 @johnjamesjacoby
8 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [4231]) Theme Compat:

  • Do not set script charset, since we are sot setting a src.
  • Fixes #1959.
  • Props plescheff.
Note: See TracTickets for help on using tickets.