Skip to:
Content

bbPress.org

Opened 11 years ago

Closed 11 years ago

#1936 closed defect (bug) (wontfix)

"Edit this page" link appearing on bbPress templates

Reported by: djpaul's profile DJPaul Owned by:
Milestone: Priority: normal
Severity: major Version:
Component: Appearance - Theme Compatibility Keywords:
Cc:

Description

One of the recent changes to trunk (aka plugin) has reintroduced the "Edit this page" and "Comments are closed" text to the footer of the page.

Change History (5)

#1 @johnjamesjacoby
11 years ago

  • Milestone changed from Awaiting Review to 2.2
  • Severity changed from normal to major

Thanks for making this ticket. I'm toying with this a bit, so it will probably come and go as 2.2 matures. Moving to the 2.2 milestone.

This is indicative of a larger theme issue. Much of the time, we (everyone/no one) do not check if the current post type supports a functionality before putting out feedback to the page. If the current post type doesn't even support comments, and comments are off (probably obviously) why output anything to the screen about comments at all?

#2 @johnjamesjacoby
11 years ago

See ​http://buddypress.trac.wordpress.org/changeset/6256/ for how BuddyPress handles this. TwentyTwelve does this in a similar fashion.

#3 @DJPaul
11 years ago

How did 2.1 work around this? Was this what setting $withcomments = false did?

#4 @johnjamesjacoby
11 years ago

It actually took totally unsetting the $post global, and relying on the theme to handle the debug notice correctly. Super sucky solution.

#5 @johnjamesjacoby
11 years ago

  • Milestone 2.2 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing this as it's expected behavior going forward. The "Edit" link is annoying, but it only appears for users that are actually able to edit those items, which will be a small subset of users at any given time.

Related: #1871

Note: See TracTickets for help on using tickets.