Skip to:
Content

bbPress.org

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#1912 closed defect (bug) (fixed)

Override logic in bbp_register_theme_package() maybe wrong

Reported by: djpaul's profile DJPaul Owned by:
Milestone: 2.1.1 Priority: normal
Severity: minor Version: 2.1
Component: Appearance - Theme Compatibility Keywords: has-patch
Cc:

Description

The logic controlling $override in bbp_register_theme_package() seems a bit off. The comment indicates that if a package of the same ID is already registered, then you need to set $override to true to override it. Right now, if $override (which defaults to true) is set to false, it won't register the package at all.

Attachments (1)

1912.01.patch​ (668 bytes) - added by DJPaul 12 years ago.

Download all attachments as: .zip

Change History (5)

@DJPaul
12 years ago

#1 @DJPaul
12 years ago

  • Keywords has-patch added

#2 @johnjamesjacoby
12 years ago

  • Milestone changed from Awaiting Review to 2.1.1

#3 @johnjamesjacoby
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4106]) Theme Compat:

  • Fix logic on theme compat override.
  • Props DJPaul.
  • Fixes #1912.
  • For 2.2 branch.

#4 @johnjamesjacoby
12 years ago

(In [4107]) Theme Compat:

  • Fix logic on theme compat override.
  • Props DJPaul.
  • Fixes #1912.
  • For 2.1 branch.
Note: See TracTickets for help on using tickets.