Subscribe/Favourite ajax links issue

[TFUME]

Topic Subscribe and Favorite ajax links stop changing after two clicks.

EG:
Click 1 -> Subscribe changes to Unsubscribe
Click 2 -> Unsubscribe changes to Subscribe
Click 3 -> Links stays on Subscribe but the user does actually subscribe to the topic and visible in profile

Can be replicated on new bbPress.org website with 2.1 forums.

[MZAWeb]

First click fires an ajax call. Second click fires an ajax call. Third click fires 2 ajax calls, and from there it doubles with each click.

After 5 clicks: ​http://screenshots.mzaweb.com/hJTq

[MZAWeb]

There's a nesting of callbacks. Removing the last line of subsLinkSetup in templates/default/js/topic.js fixes this issue. Not sure what that line is intending to do.

The line is:

subscriptionToggle.get(0).wpList.process( subscriptionToggle );

[MZAWeb]

Seems related to ​http://core.trac.wordpress.org/ticket/21152

[MZAWeb]

Ok, researched a bit more. For wp 3.4.x this in fact fixes the issue:

Removing the last line of subsLinkSetup in templates/default/js/topic.js fixes this issue.

subscriptionToggle.get(0).wpList.process( subscriptionToggle );

But due to ​http://core.trac.wordpress.org/changeset/22396 this will probably break again in 3.5

[johnjamesjacoby]

Well, that's annoying.

[johnjamesjacoby]

(In [4511]) Ajax:

• Remove call to wpList.process().
• Fixes duplicate ajax requests on topic subscriptions and favorites.
• Props MZAWeb.
• Fixes #1905 for WordPress 3.4.

[johnjamesjacoby]

Reopening to rethink for WordPress 3.5. Maybe we can do this without relying on wp-lists.

[MZAWeb]

Never got to play with wpList, but if you're ok with going pure wp_ajax_ I'd gladly take a stab at it

[johnjamesjacoby]

Replying to MZAWeb:

Never got to play with wpList, but if you're ok with going pure wp_ajax_ I'd gladly take a stab at it

Please do. There doesn't seem to be a lot to gain by relying on admin scripts, as we'll perpetually run into this situation again and again.

[MZAWeb]

Done. Looking good.

[johnjamesjacoby]

(In [4543]) Subscriptions/Favorites:

• Improvements to AJAX handling.
• Introduces bbp_ajax_response() function in common/functions.php, to handle JSON output.
• Adds AJAX failure responses.
• Props MZAWeb.
• Fixes #1905.