Skip to:
Content

Opened 22 months ago

Closed 22 months ago

Last modified 22 months ago

#1892 closed defect (fixed)

Invision Importer Replies Broken

Reported by: xiosen Owned by:
Milestone: 2.1.1 Priority: normal
Severity: normal Version: 2.1
Component: Importers Keywords: has-patch
Cc: stephen@…

Description

Just tried to use the importer to convert invision board data. Right now it fails to convert any of the replies (well actually it only converts the topic as a reply, thus duplicating the topic). This is due to it looking for a new topic in the posts table versus just the replies.

To fix change line 165 in Invision.php from:

		$this->field_map[] = array(
			'from_tablename' => 'posts', 'from_fieldname' => 'pid', 'from_expression' => 'WHERE posts.new_topic = 1',
			'to_type' => 'reply', 'to_fieldname' => '_bbp_post_id'
		);

to:

		$this->field_map[] = array(
			'from_tablename' => 'posts', 'from_fieldname' => 'pid', 'from_expression' => 'WHERE posts.new_topic = 0',
			'to_type' => 'reply', 'to_fieldname' => '_bbp_post_id'
		);

Attachments (2)

invision.diff (535 bytes) - added by netweb 22 months ago.
Invision.php (11.2 KB) - added by netweb 22 months ago.

Download all attachments as: .zip

Change History (5)

netweb22 months ago

netweb22 months ago

comment:1 netweb22 months ago

  • Cc stephen@… added
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 2.1.1

comment:2 johnjamesjacoby22 months ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4085]) Converter:

  • Fix issue with Invision converter causing replies not to be converted correctly.
  • Props netweb.
  • Fixes #1892 (2.2 branch)

comment:3 johnjamesjacoby22 months ago

(In [4086]) Converter:

  • Fix issue with Invision converter causing replies not to be converted correctly.
  • Props netweb.
  • Fixes #1892 (2.1 branch)
Note: See TracTickets for help on using tickets.