Skip to:
Content

bbPress.org

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#1876 closed defect (bug) (fixed)

Top level admin menus can conflict with other plugins

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.0
Component: General - Administration Keywords:
Cc:

Description

Because bbPress uses conventional menu_positions with its post types, it's possible that top level menu items can compete for that position, and accidentally noop each other. Currently Jigoshop has an incompatibility in this regard.

To prevent this, our menu_positions need to be something unpredictable, and bbp_admin_menu_order() needs to be refactored to specifically position menus and separators above the appearance separator (separator2).

Change History (2)

#1 @johnjamesjacoby
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4046]) Admin Menus:

  • Fix issue where bbPress top-level admin-menu positions could conflict with other plugins.
  • Set menu_position on post-types to 555555.
  • Refactor bbp_admin_menu_order() to reposition all available custom menus above the second separator.
  • Fixes #1876.

#2 @alexvorn2
11 years ago

how you made it to put in the middle of the menus with 555555 menu position? it should be at the bottom of all menus, some pure magic?

Why just don't search for free positions in the menu array?

Note: See TracTickets for help on using tickets.