Changeset 4036 appears to break widget layout

[enderandrew]

​http://bbpress.trac.wordpress.org/changeset/4036 - This did fix the issue with content from the private forums showing up in widgets, however once I updated to the latest SVN copy of bbPress, the widget itself was broken and it affected my site layout. Removing the widget fixed my site layout.

[johnjamesjacoby]

Confirmed.

[enderandrew]

It looks like the widget has one div, but two div close tags which is causing the issue. Here is the HTML the widget created post changeset 4036.

'<aside id="bbp_topics_widget-2" class="dbx-box suf-widget widget_display_topics"><div class="dbx-content"><h3 class="dbx-handle plain">Ye Olde Forums</h3><ul><li><a class="bbp-forum-title" href="​http://blindscribblings.com/topic/american-health-care-reform/" title="American Health Care Reform">American Health Care Reform</a></div></li><li><a class="bbp-forum-title" href="​http://blindscribblings.com/topic/movies-based-on-books/" title="Movies Based On Books.">Movies Based On Books.</a></div></li><li><a class="bbp-forum-title" href="​http://blindscribblings.com/forums/groups/whedon-ites/forums/topic/avengers-2/" title="Avengers 2">Avengers 2</a></div></li><li><a class="bbp-forum-title" href="​http://blindscribblings.com/topic/misnomer-and-fan-fic/" title="Misnomer and Fan-Fic">Misnomer and Fan-Fic</a></div></li><li><a class="bbp-forum-title" href="​http://blindscribblings.com/topic/new-villain/" title="Who&#039;s Going to be the NBA&#039;s New Villian?">Who&#039;s Going to be the NBA&#039;s New Villian?</a></div></li></ul></div></aside>'

[johnjamesjacoby]

(In [4037]) Widgets:

• Fix layout issue introduced in r4036.
• Fixes #1872.

[enderandrew]

I'm still having the issue with the extra </div> close tags before each </li> even after downloading this fix.

[johnjamesjacoby]

Replying to enderandrew:

I'm still having the issue with the extra </div> close tags before each </li> even after downloading this fix.

Topics widget, or replies widget? It appears fixed in both for me.

[enderandrew]

Topics widget. I cleared my browser and server cache. I downloaded the updated bbp-core-widgets.php and it produced this HMTL. Maybe something else was still cached somewhere?

'<aside id="bbp_topics_widget-2" class="dbx-box suf-widget widget_display_topics">
<div class="dbx-content">
<h3 class="dbx-handle plain">Ye Olde Forums</h3>
<ul>
<li><a class="bbp-forum-title" href="​http://blindscribblings.com/topic/american-health-care-reform/" title="American Health Care Reform">American Health Care Reform</a>
</div></li>
<li><a class="bbp-forum-title" href="​http://blindscribblings.com/topic/movies-based-on-books/" title="Movies Based On Books.">Movies Based On Books.</a></div></li>
<li><a class="bbp-forum-title" href="​http://blindscribblings.com/forums/groups/whedon-ites/forums/topic/avengers-2/" title="Avengers 2">Avengers 2</a></div></li><li><a class="bbp-forum-title" href="​http://blindscribblings.com/topic/misnomer-and-fan-fic/" title="Misnomer and Fan-Fic">Misnomer and Fan-Fic</a></div></li>
<li><a class="bbp-forum-title" href="​http://blindscribblings.com/topic/new-villain/" title="Who&#039;s Going to be the NBA&#039;s New Villian?">Who&#039;s Going to be the NBA&#039;s New Villian?</a></div></li>
</ul></div></aside>'

[johnjamesjacoby]

Unclear. Possible you're not downloading the correct file? You'll also have much better luck working with Subversion directly for this kind of thing, as manually downloading files and using FTP can be error prone.

[enderandrew]

I was at work at the time and couldn't connect directly via subversion. I just downloaded the file from the "original format" link on here, and uploaded it to my site to test the change:

​http://bbpress.trac.wordpress.org/browser/branches/plugin/bbp-includes/bbp-core-widgets.php?rev=4037

[enderandrew]

I did a full SVN checkout of the plugin branch, uploaded again and now its working.

[johnjamesjacoby]

Replying to enderandrew:

I did a full SVN checkout of the plugin branch, uploaded again and now its working.

Great thanks!