Opened 13 years ago
Closed 13 years ago
#1827 closed defect (bug) (fixed)
Methods that extend BP_Component and BP_Groups_Component can't be marked private
Reported by: | boonebgorges | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | major | Version: | |
Component: | Extend - BuddyPress | Keywords: | |
Cc: |
Description
In r3904, you marked a bunch of methods in BBP_Forums_Group_Extension and BBP_Forums_Component private or protected. This causes fatal errors, because access for the parent methods is assumed to be public in BP_Group_Extension and BP_Component.
Moreover, marking them private means that it won't be possible to unhook and then rehook these methods from outside the class, using remove_action() and add_action() (since do_action() calls call_user_func_array()
outside the scope of the class) . I don't see a reason for disallowing this kind of hook/unhook - we should default to public unless there is a good reason to mark private/protected.
Missed one