Skip to:
Content

bbPress.org

Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#1806 closed enhancement (fixed)

Option to disable topic tags

Reported by: jaredatch Owned by:
Milestone: 2.2 Priority: normal
Severity: normal Version:
Component: Component - Topic Tags Keywords: commit
Cc: stephen@…

Description

Like #1805, this could be a plugin but from what I can tell would be fairly difficult to achieve due to how tags are implemented in bbPress currently.

Some users don't feel like they have a need for topic tags - seems fair enough, I can understand that. Depending on the type of community you are running they might not be needed, or in some cases might be subject to abuse.

What about a simple checkbox in the bbPress settings - "Disable Topic Tags". Disabling would nuke the input form and the area where they show above a thread would just render empty.

Attachments (1)

1806.diff (15.9 KB) - added by jaredatch 9 years ago.

Download all attachments as: .zip

Change History (11)

#1 @jaredatch
10 years ago

Some what related, #1613. Though I would argue this might is likely separate.

#2 @jaredatch
10 years ago

  • Type changed from defect to enhancement

#3 @johnjamesjacoby
10 years ago

  • Milestone changed from Awaiting Review to Future Release

Moving to future release. I'd love for there to be a form API we can use, instead of hardcoding the template in the theme. This way any element can be removed or swapped out.

#4 @netweb
10 years ago

  • Cc stephen@… added

@jaredatch
9 years ago

#5 @jaredatch
9 years ago

  • Keywords has-patch needs-testing added; 2nd-opinion removed

First pass.

  • Allow tag option in Settings > Forum, defaults to true
  • bbp-theme-compat/TwentyTen theme checks for bbp_allow_tags before tag field output
  • register tax checks for bbp_allow_tags
  • Fixed a few things that broke. Namely functions that didn't populate variables right when tags were disabled and the bbPress Right Now dashboard widget

I'm sure there might be some other things lurking, so test away, however I did some testing with both bbp-theme-compat and twentyten and think I got any show stoppers.

The only thing I wasn't sure of was the topic-tag field in the settings. Ideally if tags are disabled there is no reason to show this. However, since it's in the middle of a settings array I wasn't sure the best method to accomplish that.

Last edited 9 years ago by jaredatch (previous) (diff)

#6 @johnjamesjacoby
9 years ago

  • Keywords commit added; has-patch needs-testing removed
  • Milestone changed from Future Release to 2.2

Patch looks good. I'll move to 2.2 and tagging as commit to get it in early, so it doesn't go stale.

#7 @johnjamesjacoby
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4098]) Topic Tags:

  • First pass to allow topic tags to be globally disabled.
  • Handles toggling the UI in template parts and admin area.
  • Props jaredatch.
  • Fixes #1806.

#8 @johnjamesjacoby
9 years ago

(In [4099]) Topic Tags:

  • Use correct setting key in settings field registration array.
  • See #1806.

#9 @Mamaduka
9 years ago

+1 for API.

How about bbp_reply_form() function, similar to comment_form()?

#10 @jaredatch
9 years ago

I agree, that would be the ultimate solution. What was implemented above was the first step. Now that the setting is in place and registering it will be easier to wrap the form elements in a parent function.

That should be a new ticket :)

Note: See TracTickets for help on using tickets.