Skip to:
Content

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#1801 closed defect (fixed)

PHP 5.4: Creating default object from empty value in bbp-includes/bbp-theme-compatibility.php on line 69

Reported by: lavoiesl Owned by:
Milestone: Priority: low
Severity: minor Version: 2.0
Component: Tools - Warnings/Notices Keywords: has-patch
Cc:

Description

Bug is present in 2.0, but the given path is for 2.1

In PHP 5.4, $object->nothing->foo = $bar gives a wonderful warning if nothing is not initialized

Patch attached

Attachments (1)

0001-patched-bbpress-theme-compat-for-5.4-warning-concern.patch (1.3 KB) - added by lavoiesl 6 years ago.

Download all attachments as: .zip

Change History (4)

#1 @johnjamesjacoby
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3830]) Introduce theme packages API for bbPress 2.1

  • Allow multiple theme packages to be registered (primarily as plugins)
  • Allow switching between theme packages on the fly
  • Register bbp-theme-compat and bbp-twentyten as available theme packages
  • Introduce new 'bbp_register_theme_packages' action, and supplemental functions
  • Introduce new option for saving the current theme package
  • Code and variable clean-up in related files
  • Fixes #1801
  • Fixes #1802

#2 follow-up: @johnjamesjacoby
6 years ago

  • Milestone Awaiting Review deleted

#3 in reply to: ↑ 2 @enderandrew
5 years ago

Replying to johnjamesjacoby:

I'm seeing a similar warning:

Warning: Creating default object from empty value in /var/www/wp-content/plugins/bbpress/bbp-includes/bbp-core-actions.php on line 267

Note: See TracTickets for help on using tickets.