Skip to:
Content

Opened 2 years ago

Closed 2 years ago

#1800 closed defect (fixed)

Update bbp-forum-template CSS Class

Reported by: netweb Owned by:
Milestone: 2.1 Priority: normal
Severity: minor Version: 2.0
Component: Actions/Filters Keywords: has-patch
Cc:

Description

Changeset 3735 modified some CSS Class names in bbpress.css
.bbp-forum-description was changed to .bbp-forum-content

(http://bbpress.trac.wordpress.org/changeset/3735/branches/plugin/bbp-theme-compat/css/bbpress.css)

Update for /plugin/bbp-includes/bbp-forum-template.php change #L1816

FROM: 'before' => '<div class="bbp-template-notice info"><p class="bbp-forum-description">',

TO: 'before' => '<div class="bbp-template-notice info"><p class="bbp-forum-content">',

(http://bbpress.trac.wordpress.org/browser/branches/plugin/bbp-includes/bbp-forum-template.php#L1816)

Attachments (2)

bbp-forum-template.php (75.5 KB) - added by netweb 2 years ago.
bbPress.1800.diff (543 bytes) - added by netweb 2 years ago.

Download all attachments as: .zip

Change History (11)

netweb2 years ago

comment:1 netweb2 years ago

Be Gentle, my first ever patch submitted :)

Sadly I was hoping the patch would show up as a 'diff' oh well, had hoped for ...ticket/1800/1800.diff, maybe next time, at least its accurate (Line #1816)!

Will read more trac docs... Have only just started using GitHub for VCS! Grokking slowly...

comment:2 alexvorn22 years ago

please upload the diff, can help you to generate the file if it is hard for you...

netweb2 years ago

comment:3 follow-up: netweb2 years ago

  • Severity changed from normal to minor

Ok... I think I got it this time :)

comment:4 in reply to: ↑ 3 johnjamesjacoby2 years ago

Replying to netweb:

Ok... I think I got it this time :)

Nicely done! Thanks!

comment:5 johnjamesjacoby2 years ago

  • Milestone changed from Awaiting Review to 2.1

comment:6 johnjamesjacoby2 years ago

(In [3834]) Add missing styling to bbp-forum-content in theme compat. See #1800.

comment:7 johnjamesjacoby2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3835]) Tweak bbp-forum-content and bbp-forums-list styling. Fixes #1800.

comment:8 follow-up: netweb2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Patch was not applied :)

comment:9 in reply to: ↑ 8 johnjamesjacoby2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to netweb:

Patch was not applied :)

It didn't need to be. Changing the class in that one place is not enough to fix the problem.

bbp-forum-content is the wrapper class for the actual content area of a forum. bbp-forum-description is used in two places: index/subforums, and the header description.

Note: See TracTickets for help on using tickets.