Skip to:
Content

bbPress.org

Opened 9 years ago

Closed 9 years ago

#1796 closed defect (fixed)

bbp-twentyten needs to be reverted to use tables

Reported by: johnjamesjacoby Owned by: johnjamesjacoby
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.0
Component: Appearance - Theme Compatibility Keywords:
Cc:

Description

Many users have tweaked the included CSS of bbp-twentyten and rely on the theme itself using table based CSS. Since bbp-theme-compat is the canonical back-up for missing template files, it's safest to revert bbp-twentyten back to using tables.

Change History (8)

#1 @johnjamesjacoby
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3820]) Revert bbp-twentyten back to table based layout:

  • bbp-theme-compat retains tableless layout, and is canonical backup for missing template files
  • Avoid back-compat issues with installs that have modified bbPress 2.0 CSS
  • Fixes #1796

#2 @johnjamesjacoby
9 years ago

(In [3821]) Remove 'bbpress/' from template part calls in bbp-twentyten.

  • Sub folders are handled automatically by bbp_get_template_part()
  • See #1796

#3 @alexvorn2
9 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I can say that tableless layout can be more flexible to style in CSS while tables work better for older browsers.
I think you should choose what to use for both... my vote goes for tableless layout.

#4 @anointed
9 years ago

Tables are fine and dandy until you start getting real serious about building responsive layouts. I couldn't even begin to imagine how difficult it would have been to build out using tables. If it's still open to a vote, I'd definitely go with tableless layouts.

There are a number of really great articles published lately on just how much a pain tables are when it comes to responsive design. Even the best examples out there admittedly are pretty handcuffed.

#5 @jaredatch
9 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

If you want tableless just don't use bbPress TwentyTen. The bbPress theme compat theme that is built in 2.1 is still tableless :)

#6 follow-up: @alexvorn2
9 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

You don't get the point!
As a WordPress theme developer I create themes... For making the bbPress compatible with my themes I should do the CSS code layout for tables and tableless, which will consume my and everyone's time who will want to do the same.

In real life it is like having two identical cars if you just use only one. Lame...

I will not support bbPress in my themes if it goes in this way... and will not use this plugin that is going to fail like Windows 8...

You should listen to users who actually USE the plugin for main purposes not just working on it...

jaredatch - do you use the plugin for an actual website? no? :D

#7 @jaredatch
9 years ago

I don't quite get what your point is, but I'm fairly certain you are missing mine entirely.

bbPress TwentyTen uses tables. The default 2.1 bbPress theme does not (bbp theme compat).

Everything new, moving forward, is going to be tableless. However *IF* bbPress TwentyTen went tableless anyone who upgrades to 2.1 and has CSS in place to deal with the original table layout would see some serious breakage. So why would we want to cause that??

In the future bbPress TwentyTen is going to be phased out completely.

You're right, I just submit patches and plugins for bbPress but don't actually use it for any of my clients in a production environment. *roll eyes*

Last edited 9 years ago by jaredatch (previous) (diff)

#8 in reply to: ↑ 6 @johnjamesjacoby
9 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to alexvorn2:

You don't get the point!
As a WordPress theme developer I create themes... For making the bbPress compatible with my themes I should do the CSS code layout for tables and tableless, which will consume my and everyone's time who will want to do the same.

In real life it is like having two identical cars if you just use only one. Lame...

I will not support bbPress in my themes if it goes in this way... and will not use this plugin that is going to fail like Windows 8...

You should listen to users who actually USE the plugin for main purposes not just working on it...

jaredatch - do you use the plugin for an actual website? no? :D

The back-and-forth open/close is not cool; treating others like they are less than you are is not cool. This theme needs to use tables because users that modified the original CSS will lose all of their changes.

All of the files in bbp-theme-compat are tableless. Clearly that's the way to be going forward, but the table based layout in bbp-twentyten needs to stay.

Do not reopen this ticket again. It's fixed. Case closed.

Note: See TracTickets for help on using tickets.