#1791 closed defect (bug) (fixed)
Tags field only populates on reply/topic edit page
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 2.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Component - Replies | Keywords: | 2nd-opinion |
Cc: |
Description
More from #1785.
Alright, I've done some digging and tracked this down.
form-reply.php
in both 2.0 and 2.1 uses bbp_form_topic_tags()
to fill in the tags for the reply area that shows up on the bottom of.
However, that function (well, bbp_get_form_topic_tags()
) is different between 2.0 and 2.1.
In 2.0 we have this:
// Get edit data } elseif ( !empty( $post ) ) {
In 2.1 we have:
// Get edit data } elseif ( bbp_is_topic_edit() || bbp_is_reply_edit() ) {
Because 2.1 checks to see if it is a topic/reply edit the tags only populate on those pages.
For example:
http://wptrunk/forums/topic/this-is-a-topic/ - tags do not get populated in the reply tags field
http://wptrunk/forums/topic/this-is-a-topic/edit/ - tags get populated
Due to the way tags are setup, it makes more sense the way it was in 2.0, where the tags are auto populated on all pages, not just the topic/reply edit pages.
Does this make sense? I can explain better via IRC if needed. I guess I just don't understand the change to the bbp_get_form_topic_tags()
in 2.1 - specifically why it checks for reply/topic edit pages.
If this was a mix-up, patch is attached that reverts it back to 2.0 functionality.
(In [3810]) Make sure topic tags appear on single topics and replies. Props jaredatch. Fixes #1791.