Skip to:
Content

bbPress.org

Opened 9 years ago

Closed 9 years ago

#1766 closed task (fixed)

General theme compatibility improvements

Reported by: johnjamesjacoby Owned by: johnjamesjacoby
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.0
Component: Appearance - Theme Compatibility Keywords:
Cc:

Description

Theme compatibility needs some auditing before 2.1 is ready for launch. Use this ticket for any changes.

Change History (6)

#1 @johnjamesjacoby
9 years ago

(In [3779]) Setup default theme compatibility in bbPress::setup_theme()

  • Sets early on bbp_setup_theme so functions and files can be included
  • Still allows plugins to override earlier
  • See #1766

#2 @johnjamesjacoby
9 years ago

(In [3780]) In bbp-twentyten:

  • Rename functions.php to bbpress-functions.php to avoid overloading
  • Load JS in footer
  • Smarter default global vars
  • Do not create a global variable
  • See #1766

#3 @johnjamesjacoby
9 years ago

(In [3781]) Pass param to bbp_get_template_locations() to allow locations to be filtered based on templates being queried. See #1766.

#4 @johnjamesjacoby
9 years ago

(In [3782]) Turn BBP_Default class into smarter default for theme compat

  • Additional comments to help theme developers move files around
  • Check theme support, and tweak the defaults as needed
  • Use the pinking shears
  • Use local variables for script locations
  • See #1766

#5 @johnjamesjacoby
9 years ago

(In [3783]) Remove theme setup action from bbp-core-actions.php, as it's now in the bbPress class.

  • Tweak inline doc for bbp_load_theme_functions action
  • Trust bbp_setup_theme_compat() to set the theme compat regardless of what's there
  • See #1766

#6 @johnjamesjacoby
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Currently all permutations of theme setups are working for bbPress 2.1. Closing this as fixed. New bugs should get new tickets.

Note: See TracTickets for help on using tickets.