Merge Closed topics too

[alexvorn2]

Now we can merge only open topics but why we can't merge the closed ones?

Of course there can be used a filter in the function but it would be great to add a settings option so we could merge closed topics too.

[cnorris23]

I've not done much merging, but looking at the code involved, there's doesn't appear to be any reason that closed topics can't be merged. At least not in the upcoming 2.1 code.

[alexvorn2]

We can merge a closed topic with an open topic, BUT we can't merge a closed with another closed, or an opened with a closed one.

[netweb]

Related #1925.

Moving this to the 2.6 milestone, not so much the original issue/description of this ticket but the SQL queries related to this ticket are closely related to and any changes that will be made via #1925 and will affect these types of functions and need to be tested thoroughly.

[johnjamesjacoby]

I believe this was less about the technical aspects, and more about how to pick which topic properties to inherit when merging. Do we assume all the destination topic's status/visibility/forum/etc…? Or provide a UI to cherry pick between the two of them.

[netweb]

Replying to johnjamesjacoby:

I believe this was less about the technical aspects, and more about how to pick which topic properties to inherit when merging. Do we assume all the destination topic's status/visibility/forum/etc…? Or provide a UI to cherry pick between the two of them.

I think if the topic is visible and status is open (publish) or closed you should be able to merge.

I was 'testing' something last night and noticed this was a very slow query and was going to open a ticket then saw this ticket and thought two birds, but now after looking at the code it isn't really relevant and would be taken care of automatically by whatever method is used in #1925.

Patch 1714.diff adds support to merge a topic into a closed topic.

[johnjamesjacoby]

In 5313:

Allow closed topics to be split and merged into. Props netweb. Fixes #1714.