Skip to:
Content

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#1699 closed task (fixed)

Remove deprecated function add_contextual_help

Reported by: Mamaduka Owned by:
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.0
Component: General - Administration Keywords: has-patch
Cc:

Description

With WordPress 3.3 add_contextual_help() function is deprecated, need to update them with new add_help_tab() function.

Here's dev note from Nacin about Help and screen API changes in 3.3

Attachments (1)

1699.diff (8.7 KB) - added by Mamaduka 7 years ago.

Download all attachments as: .zip

Change History (11)

#1 @johnjamesjacoby
7 years ago

  • Milestone changed from Awaiting Review to 2.1

#2 @Mamaduka
7 years ago

Working on a patch, but add_help_tabs is little tricky to use with CPT and how bbPress added contextual help before. One problem is that calling setup_help() in construct is early for WP_Screen, I attached setup_help() function to load-$pagenow hook but it needs extra logic like - is it forum post type, is it edit or add screen.

#3 @johnjamesjacoby
7 years ago

(In [3685]) Refactor bbp_admin_settings_help() to use add_help_tab() and set_help_sidebar(). See #1699.

#4 @johnjamesjacoby
7 years ago

(In [3686]) Refactor forum/topic/reply contextual help, shamelessly sampled from the WordPress 'post' content type. See #1699.

#5 @johnjamesjacoby
7 years ago

(In [3687]) Hook missing forum contextual help in. See #1699.

#6 @johnjamesjacoby
7 years ago

  • Resolution set to fixed
  • Status changed from new to closed
  • Type changed from enhancement to task

Closing this as fixed,as the bulk of the code changes are in. Would love if someone would comb through the verbiage and check for feature pairity since it's largely lifted from WordPress core.

@Mamaduka
7 years ago

#7 @Mamaduka
7 years ago

  • Keywords has-patch added; needs-patch removed

Previous changes to contextual help where missing forum/topic/reply Attributes box help tabs, also I believe there are no pages in Codex for forum/topic/reply Formats, so for now links will redirect users to Post Format page.

#8 @Mamaduka
7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#9 @johnjamesjacoby
7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [3688]) Add attributes to forum/topic/reply contextual help. Props Mamaduka. Fixes #1699.

#10 @johnjamesjacoby
7 years ago

(In [3718]) Add description to Group Forums Parent setting. Remove check for forums not being active, as this will be handled by migration later. See #1699.

Note: See TracTickets for help on using tickets.