Skip to:

Opened 8 years ago

Closed 8 years ago

#1698 closed defect (fixed)

Audit use of suppress_filters checks and pre_get_posts usage

Reported by: johnjamesjacoby Owned by: johnjamesjacoby
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.0
Component: General - Integration Keywords:


In bbp_pre_get_posts() and bbp_pre_get_posts_exclude_forums() we are hooking into WordPress's pre_get_posts action and checking for suppress_filters. Per Nacin's post this deserves a second look. In addition, bbp_pre_get_posts() might be more correctly placed on the 'parse_query' action instead of 'pre_get_posts' so test this out and make sure nothing breaks.

Change History (2)

#1 @johnjamesjacoby
8 years ago

(In [3646]) 'suppress_filters' audit:

  • Revert part of r3645
  • Rename bbp_pre_get_posts() to bbp_parse_query() and hook to 'parse_query'
  • Move forum post_type check out of bbp_pre_get_posts() and into bbp_pre_get_posts_exclude_forums() where it makes more sense
  • Update documentation for above changes
  • See #1698

#2 @johnjamesjacoby
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

r3646 fixed this

Note: See TracTickets for help on using tickets.