Skip to:
Content

bbPress.org

Opened 13 years ago

Closed 13 years ago

#1692 closed defect (bug) (worksforme)

Use if is_a() will throw E_STRICT warnings

Reported by: cnorris23's profile cnorris23 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Tools - Warnings/Notices Keywords: needs-patch
Cc:

Description

WP's minimum requirement is 5.2.4. As of PHP 5.0.0, is_a() was deprecated. This was reverted in PHP 5.3, but bbPress should account for this. PHP documentation recommends using instanceof, ie 

!( $bbp instanceof bbPress )

Change History (2)

#1 @cnorris23
13 years ago

I should also state that this is in reference to [3627]

#2 @johnjamesjacoby
13 years ago

  • Milestone 2.1 deleted
  • Resolution set to worksforme
  • Status changed from new to closed

WordPress core uses is_a() in many different places, so while a valid report, I'm assuming it's safe enough for us. I considered this when I made the changes.

Good catch though!

Note: See TracTickets for help on using tickets.