Skip to:
Content

bbPress.org

Opened 15 years ago

Closed 14 years ago

#1671 closed defect (bug) (fixed)

Invalid default argument key "sort_column" in bbp_forum_get_subforums()

Reported by: ericlewis's profile ericlewis Owned by:
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.0
Component: Component - Forums Keywords:
Cc:

Description

Came across this today when I noticed subforums sorting strangely on the forums homepage. Found out they were actually sorting by ID, which is because in the $default array the key being used is 'sort_column', not 'orderby', which I'm assuming was an oversight while converting all forums over to CPTs in BBP 2.0.

I've changed the key to 'orderby', and also took out ", post_title" as the 'orderby' argument expects only one value, which I left as "menu_order"

Attachments (1)

1671.diff​ (492 bytes) - added by ericlewis 15 years ago.
patch for basic fix.

Download all attachments as: .zip

Change History (4)

@ericlewis
15 years ago

patch for basic fix.

#1 @ericlewis
15 years ago

  • Component changed from Administration to Forums

#2 @johnjamesjacoby
15 years ago

  • Milestone changed from Awaiting Review to 2.1

#3 @johnjamesjacoby
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3622]) Fix subforum ordering in bbp_forum_get_subforums(). Fixes #1671. Props ericlewis.

Note: See TracTickets for help on using tickets.