Skip to:
Content

bbPress.org

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1660 closed defect (bug) (fixed)

bbp_is_(de)activation() do not account for bulk actions

Reported by: duck_ Owned by:
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.0
Component: API - Installation/Upgrade Keywords: has-patch reporter-feedback
Cc:

Description

bbp_is_activation() and bbp_is_deactivation() do not account for bulk activations/deactivations.

This isn't an issue for activation since the function isn't actually used. On deactivation it means that the rewrite rule flushing doesn't work as hoped and the bbPress rewrite rules remain after deactivation.

Attached is a patch that should deal with the issue for deactivation only. It should be easy to port to activation if you like the approach :)

Attachments (1)

bbp_is_deactivation.diff (1.5 KB) - added by duck_ 10 years ago.

Download all attachments as: .zip

Change History (7)

#1 @duck_
10 years ago

From bbp_is_deactivation.diff it looks like

! $action ||

is redundant and can be removed if/when it's applied.

#2 @johnjamesjacoby
10 years ago

  • Milestone changed from 2.0.1 to 2.1

#3 @johnjamesjacoby
10 years ago

duck_ - I like it. Can you patch for activation too?

#4 @johnjamesjacoby
10 years ago

  • Keywords reporter-feedback added

#5 @johnjamesjacoby
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3657]) Improve bbp_is_activation() and bbp_is_deactivation() to include bulk actions. Props duck_. Fixes #1660.

#6 @johnjamesjacoby
10 years ago

(In [3658]) Fix 'deactivate' copy-pasta from r3657. See #1660.

Note: See TracTickets for help on using tickets.