Skip to:
Content

bbPress.org

Opened 15 years ago

Closed 15 years ago

#1657 closed defect (bug) (fixed)

Contextual help text fixes

Reported by: duck_ Owned by:
Priority: normal Milestone: 2.1
Component: General - Administration Version: 2.0
Severity: normal Keywords: has-patch
Cc:

Description

Attached is a fix for the following issues:

$contextual_help = array();
...
$contextual_help .= '<p>' . $paragraph . '</p>';

Causes "Array" to appear at the top of contextual help, see help on the New Forum page for example.

Topic New/Edit help is overwritten by the topic Post Rows help.

Unnecessary global $bbp that was missed in [3348].

:)

Attachments (1)

bbp.1657.diff​ (2.8 KB ) - added by duck_ 15 years ago.

Download all attachments as: .zip

Change History (5)

@duck_
15 years ago

#1 @duck_
15 years ago

Might also want to consider just passing '<p>' . implode( '</p><p>', $bbp_contextual_help ) . '</p>' (untested) to add_contextual_help() and dumping $contextual_help.

#2 @GautamGupta
15 years ago

  • Milestone Awaiting Review → 2.0.1

#3 @johnjamesjacoby
15 years ago

  • Milestone 2.0.1 → 2.1

#4 @johnjamesjacoby
15 years ago

  • Resolution → fixed
  • Status new → closed

(In [3583]) Contextual help fixes. Fixes #1657. Props duck_

Note: See TracTickets for help on using tickets.