Skip to:
Content

bbPress.org

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1610 closed defect (fixed)

Small CSS problems

Reported by: pavelevap Owned by:
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.0
Component: General - UI/UX Keywords: needs-patch
Cc: pavelevap@…, Mamaduka

Description

1) Username in reply is moved to the right (only in IE9). Please see attached screenshot IE9_reply_username.png.

2) A little longer translation of "Notify me of follow-up replies via email" shows checkbox at the bottom. Please see attached screenshot Notify_checkbox.png.

Attachments (3)

IE9_reply_username.png (21.7 KB) - added by pavelevap 10 years ago.
Notify_checkbox.png (5.7 KB) - added by pavelevap 10 years ago.
notify-checkbox.2.png (7.5 KB) - added by Mamaduka 10 years ago.

Download all attachments as: .zip

Change History (13)

#1 @GautamGupta
10 years ago

  • Milestone changed from Awaiting Review to 2.0

(1) Also happens in Firefox.

#2 @Ramoonus
10 years ago

  • Keywords needs-patch added

#3 @johnjamesjacoby
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3492]) Add 'sep' argument to topic and reply author links. Pass line breaks in loops. Fixes #1610.

#4 @pavelevap
10 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Ad 1) Works well, thank you.

Ad 2) Not solved, I am reopening this ticket. It looks really strange and there is blank place so no need to made two rows from this checkbox notice.

#5 follow-up: @GautamGupta
10 years ago

I think we should move the input tag inside the label tag and do a few CSS edits, like removing the enforced width.

#6 @johnjamesjacoby
10 years ago

  • Milestone changed from 2.0 to 2.1

#7 @GautamGupta
10 years ago

  • Milestone changed from 2.1 to 2.0.1

#8 in reply to: ↑ 5 @Mamaduka
10 years ago

  • Cc Mamaduka added

Replying to GautamGupta:

I think we should move the input tag inside the label tag and do a few CSS edits, like removing the enforced width.

Or we can just remove

display: inline-block;

but then <label> tag will ignore width property and if width is really needed, we should move it to the wrapper <p> tag.

I can provide patch if you like my solution

#9 @johnjamesjacoby
10 years ago

  • Milestone changed from 2.0.1 to 2.1
  • Resolution set to fixed
  • Status changed from reopened to closed

Inputs shouldn't be inside labels. I've tweaked the CSS some in the plugin branch.

#10 @Mamaduka
10 years ago

Replying to johnjamesjacoby:

Inputs shouldn't be inside labels. I've tweaked the CSS some in the plugin branch.

You removed fixed with for label, but display: inline-block; still remains. It will be also ugly if translated text is big and wrapped in few lines. See attached image

Note: See TracTickets for help on using tickets.