Skip to:
Content

bbPress.org

Opened 10 years ago

Closed 10 years ago

#1573 closed defect (bug) (fixed)

$wp_rewrite->pagination_base not used

Reported by: scribu Owned by: johnjamesjacoby
Milestone: 2.0 Priority: normal
Severity: normal Version: 2.0
Component: General - Administration Keywords: has-patch
Cc:

Description

WP 3.1 introduced the pagination_base variable, which should be used instead of hardcoding /page/:

http://core.trac.wordpress.org/ticket/12507

Attachments (2)

1573.diff (6.2 KB) - added by scribu 10 years ago.
1573.2.diff (6.6 KB) - added by scribu 10 years ago.
Handle bbp_reply_url() as well

Download all attachments as: .zip

Change History (5)

@scribu
10 years ago

#1 @scribu
10 years ago

The patch is generated from git, but can be applied easily using patch -p1 < 1573.diff

@scribu
10 years ago

Handle bbp_reply_url() as well

#2 @johnjamesjacoby
10 years ago

  • Milestone changed from Awaiting Review to 2.0
  • Owner set to johnjamesjacoby

Looks good to me.

#3 @johnjamesjacoby
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3361]) Fix pagination issues when using topics shortcode on front page. Also use pagination_base instead of 'page'.

Fixes #1567, #1573. Props scribu.

Note: See TracTickets for help on using tickets.